Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenSL ES buffer callbacks on Android #9

Closed
wants to merge 1 commit into from
Closed

OpenSL ES buffer callbacks on Android #9

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 21, 2015

This is an alternate solution to the problem described in pull request #8.

I changed the stop function to destroy the buffer queue object before freeing the buffer. Calling Destroy on the buffer queue seems to block until any running callbacks are done and prevent any further callbacks. I also moved the realization of the buffer queue object from the reset to the start function. This way the start function can re-realize the object after it was destroyed by the stop function.

@ghost ghost mentioned this pull request Apr 21, 2015
@kcat
Copy link
Owner

kcat commented Apr 21, 2015

Doesn't the Destroy method invalidate the bufferQueueObject? It's not guaranteed that the reset method will be called in between stop and start.

@ghost
Copy link
Author

ghost commented Apr 21, 2015

Yes, you're right. My mistake. Since in that case I'm not sure how to resolve this problem, i will open an issue instead.

@ghost ghost closed this Apr 21, 2015
@ghost ghost deleted the opensl_queue_fix branch April 21, 2015 15:27
@xuandu xuandu mentioned this pull request Jun 2, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants