Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

althrd_starter data race #7

Closed
galek opened this issue Apr 5, 2015 · 7 comments
Closed

althrd_starter data race #7

galek opened this issue Apr 5, 2015 · 7 comments

Comments

@galek
Copy link

galek commented Apr 5, 2015

Hi
i found data race in thread althrd_starter.

detected using vs2015 and VTune.

In my engine used task based threading.
and updating listener position is task

@kcat
Copy link
Owner

kcat commented Apr 5, 2015

I'm not sure I see where the race condition is in althrd_starter. Can you clarify what the problem is?

@galek
Copy link
Author

galek commented Apr 6, 2015

I found it using the package VTune, or Visual studio profiler.
Just this detected is regularly.

If I will remove thread support ,much do I lose?I honestly did not delve into the code of OpenAL..

@kcat
Copy link
Owner

kcat commented Apr 7, 2015

OpenAL Soft requires threading to do background processing, including audio mixing.

Does VTune or the Visual Studio Profiler describe what the race condition is? I'm still not able to see the problem.

@galek
Copy link
Author

galek commented Aug 12, 2015

sorry me for long time.

VS-profiler says what race with main thread.

Xm, I will check how fixed this problem-so maybe problems from my implementation of threads (It's based on Task-Based model. Updating audio is another task)

@galek
Copy link
Author

galek commented Feb 10, 2016

sorry me for long time, again, but problem is still on 1.17.1

Compiler: VS2015 update 1

So how i can make own solution for mixing?(I have own system of threads)

@kcat
Copy link
Owner

kcat commented Feb 11, 2016

Unfortunately I still don't know what the issue is. althrd_starter is just a launchpad function, it's given to the WinAPI thread function (CreateThread) and in turn calls the caller-supplied function. I don't see any race condition in the code. What information you can give me about where the problem is? Line numbers, conditions, execution order, callers, etc, would be helpful.

@kcat
Copy link
Owner

kcat commented May 28, 2017

Closing due to lack of information on what the problem actually is. All tests I've done check out fine, and there's no information here to show where there's a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants