Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checking isEmpty on features causes extraneous console.logs #56

Open
bttf opened this issue Jun 20, 2017 · 1 comment
Open

Checking isEmpty on features causes extraneous console.logs #56

bttf opened this issue Jun 20, 2017 · 1 comment

Comments

@bttf
Copy link

bttf commented Jun 20, 2017

Using Ember.isEmpty on the features service outputs in the console:

Feature flag off: size
Feature flag off: length

I can probably look at this later since it seems like an easy fix. Using this as a reminder

@buschtoens
Copy link

This is, because by the checking presence, you are accessing the feature flag, through the unknownProperty trap, which defaults to false, if the flag is not set. So this would not work anyway. See #31 for more ccontext.

What you would require is something like an isSet method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants