Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disableFeature test helper not available in current release #107

Open
nwhittaker opened this issue Apr 29, 2021 · 6 comments
Open

disableFeature test helper not available in current release #107

nwhittaker opened this issue Apr 29, 2021 · 6 comments

Comments

@nwhittaker
Copy link

The README indicates a disableFeature test helper is available[1]. However, the 6.0.0 release does not include this test helper which was added later via #97.


[1] https://github.com/kategengler/ember-feature-flags#enablefeature--disablefeature

@kategengler
Copy link
Owner

The README will always document the main branch, if you want to see documentation for old version you can view the README for the tag https://github.com/kategengler/ember-feature-flags/tree/v6.0.0

Are you asking for a release?

@nwhittaker
Copy link
Author

Are you asking for a release?

I was hoping for that outcome, yes. Is that doable?

@timiyay
Copy link

timiyay commented Aug 23, 2021

I've hit this bug today, when attempting to use disableFeature and getting back:

TypeError: (0, _testSupport.disableFeature) is not a function

If a release of this package reinstates this function, is it possible to get a 6.0.1 release to fix this issue?

@sepuckett86
Copy link

I agree with the above comments -- I'd be interested in using disableFeature when a 6.0.1 release is possible.

@SergeAstapov
Copy link
Contributor

+1 for the release.

@kategengler is there anything we could do to help with releasing new version?

@Techn1x
Copy link
Contributor

Techn1x commented Aug 4, 2023

I contributed this feature back in 2020
#97

I had already been wanting disableFeature for a long time before that, that's why I contributed it.

I feel my contribution has actually had a negative effect, as people attempt to use it based on its presence in the README, and then they waste a bunch of time trying to get it to work (or even authoring & structuring test code around the assumption that the test helper exists), before realising that this addon hasn't cut a release in 4 years.

I would appreciate a release being cut with my contribution, though I understand that this addon may not be in a state where doing a patch a release is straightforward.

Should this addon be donated to the adopted addons project? It seems like a strong candidate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants