Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add non-panicking variants to cgroups_rs::memory::MemController::memory_stat #137

Closed
sisungo opened this issue May 26, 2024 · 1 comment
Closed
Labels
enhancement New feature or request needs-review

Comments

@sisungo
Copy link

sisungo commented May 26, 2024

Which feature do you think can be improved?
When cgroup2 filesystem is unmounted as the program is running and the method is called later, the method triggers a panic!(). The panic is located at .unwrap() at line 587 in memory.rs.

This behavior is not documented and may make things like writing the init daemon have an unexpected behavior.

How can it be improved?
This issue request to add a non-panicking variant to methods like this. The non-panicking methods may have names like try_xxx() and returns a Result<_>.

@sisungo sisungo added enhancement New feature or request needs-review labels May 26, 2024
@sisungo
Copy link
Author

sisungo commented Jun 7, 2024

Duplicates with #116.

@sisungo sisungo closed this as completed Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs-review
Projects
None yet
Development

No branches or pull requests

1 participant