Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select2 size #121

Closed
RomeroMsk opened this issue Jul 30, 2014 · 3 comments
Closed

Select2 size #121

RomeroMsk opened this issue Jul 30, 2014 · 3 comments

Comments

@RomeroMsk
Copy link

Size config is not working. When using pluginLoading, class of input will not change to input-sm (for example) after showing the widget. And even if pluginLoading is false, class will not change to input-sm because first condition here is always false:
https://github.com/kartik-v/yii2-widgets/blob/master/widgets/Select2.php#L158
(I think you forgot about setting addon to empty array: https://github.com/kartik-v/yii2-widgets/blob/master/widgets/Select2.php#L51).

@RomeroMsk
Copy link
Author

Thanks, now it works. There is small issue with css: .select2-container-multi .select2-choices .select2-search-field input have height: 32px, but when using small size it is better to set it to 30px:
image

@kartik-v
Copy link
Owner

A few more enhancements added and demo site updated to include the various sizes for single and multiple and with addons.

@RomeroMsk
Copy link
Author

Yep, it's fine now. Thanks again for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants