Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call model.eval() before generating? #16

Open
gustavdelius opened this issue Apr 23, 2023 · 1 comment
Open

Call model.eval() before generating? #16

gustavdelius opened this issue Apr 23, 2023 · 1 comment

Comments

@gustavdelius
Copy link

I understand why we have to call model.eval() before calculating the average loss in estimate_loss(). But should we not similarly call model.eval() before we start generating from the model?

@manudwd
Copy link

manudwd commented May 14, 2023

You should be calling model.eval() at the time of inference, that is, if you want to set the affect of weights post normalization and dropout. Without setting model.eval() there is no effect of dropout and normalization at the time of testing. I believe that is just something that was forgotten.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants