Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal for New Label for Testing PRs #5506

Open
mohamedawnallah opened this issue Sep 9, 2024 · 8 comments
Open

Proposal for New Label for Testing PRs #5506

mohamedawnallah opened this issue Sep 9, 2024 · 8 comments
Assignees
Labels
kind/question Indicates an issue that is a support question.
Milestone

Comments

@mohamedawnallah
Copy link
Contributor

mohamedawnallah commented Sep 9, 2024

Description

I wanted to discuss the possibility of introducing a new label for pull requests, such as kind/test. Currently, PRs that involve adding unit tests and end-to-end tests don't fit neatly into the existing kind/failing-test or kind/feature categories. This misalignment could lead to confusion and make it harder to track and manage these PRs effectively.

Introducing a kind/test label could help in categorizing and organizing these PRs more clearly, preventing any potential messiness and ensuring that they are labeled properly.

What are your thoughts on this proposal?

cc: @XiShanYongYe-Chang, @zhzhuang-zju

@mohamedawnallah mohamedawnallah added the kind/question Indicates an issue that is a support question. label Sep 9, 2024
@zhzhuang-zju
Copy link
Contributor

Introducing the label kind/test is a good idea. Should we keep the previous label kind/failing-test or remove it?

@mohamedawnallah
Copy link
Contributor Author

mohamedawnallah commented Sep 9, 2024

IMHO, the kind/failing-test label might not be necessary, as its description states: Categorizes issue or PR as related to a consistently or frequently failing test.. That said, others may have different views, or some users might find this label useful.

@zhzhuang-zju
Copy link
Contributor

I think we can keep it for now. kind/failing-test can serve as a supplement to kind/test, providing more detailed categorization.

@XiShanYongYe-Chang
Copy link
Member

I agree that a dedicated label that focuses on tests is needed to represent test-related code, which includes subsequent UT and E2E code additions.

Is there a specific action plan?

@mohamedawnallah
Copy link
Contributor Author

@XiShanYongYe-Chang I think adding labels is restricted to those with admin privileges?

@XiShanYongYe-Chang
Copy link
Member

cc @RainbowMango

@RainbowMango
Copy link
Member

It makes sense to me that have a label for testing efforts.
/assign

It might take some time as currently we have a lot of more priority stuff and I also need some time to test if the label could be handled by karmada-bot.

@RainbowMango RainbowMango added this to the v1.12 milestone Sep 10, 2024
@liangyuanpeng
Copy link
Contributor

liangyuanpeng commented Sep 10, 2024

this can resolved by:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/question Indicates an issue that is a support question.
Projects
None yet
Development

No branches or pull requests

5 participants