Syntax error in source, causes fatal error

[mryellow]

Mostly a workflow issue when running under gulp. When running "progress" only, any syntax errors are spat out in console and watch gulp task continues to run. However when "junit" is added to the reporters the same situation will fail on att of undefined and watch will be exited.

Would checking for suite before attempting to use it be an acceptable fix? Go ahead and PR?

Same lack of validation as #16 and karma-runner/karma-coverage#70, the existing fix #17 seems to have been lost at some stage.

[mryellow]

Current implementation of old fix to onBrowserComplete:

karma-junit-reporter/index.js

Lines 78 to 80 in 4c2abd0

	if (!suite || !result) {
	return // don't die if browser didn't start
	}

Same idea in writeXmlForBrowser:

karma-junit-reporter/index.js

Lines 44 to 46 in 4c2abd0

	if (!xmlToOutput) {
	return // don't die if browser didn't start
	}

Missing from initliazeXmlForBrowser.

Think browser.id in onBrowserComplete may need checking also.

Fixes are missing from onBrowserComplete here https://github.com/karma-runner/karma-junit-reporter/blob/v0.3.4/index.js#L74

[martinmicunda]

+1 for fix

[osherx]

+1

[mryellow]

Not sure it needs a PR, linking master branch without commit hash, looks like it has everything:

https://github.com/karma-runner/karma-junit-reporter/blob/master/index.js#L44-L46

https://github.com/karma-runner/karma-junit-reporter/blob/master/index.js#L78-L80

This one missing, could probably do with a check here too:

https://github.com/karma-runner/karma-junit-reporter/blob/master/index.js#L31

Where tag v.0.3.4 is missing these:

https://github.com/karma-runner/karma-junit-reporter/blob/v0.3.4/index.js

Seems onBrowserComplete check was removed in this commit, then later fixed and not merged back in:

e4f7ebd#diff-168726dbe96b3ce427e7fedce31bb0bc

Can't find when the writeXmlForBrowser bit came along or was removed, a whole bunch of back and forth recently with filename stuff in that one.

[theBull]

+1

Any luck with a fix for this?