Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report file always saves to project root as "test-results.xml" #33

Closed
zsiswick opened this issue Feb 11, 2015 · 12 comments
Closed

Report file always saves to project root as "test-results.xml" #33

zsiswick opened this issue Feb 11, 2015 · 12 comments

Comments

@zsiswick
Copy link

Following the example on the readme, when I edit this line: outputFile: 'reports/results.xml', it won't save the report in the reports folder, nor rename the file to "results.xml"

@busches
Copy link

busches commented Apr 10, 2015

I'm not able to reproduce this, if I have

junitReporter: {
  outputFile: 'test-moo.xml'
},

It spits out a test-moo.xml file. Can you provide your exact configuration to reproduce?

@dmitry
Copy link

dmitry commented Apr 25, 2015

Works for me with junitReporter. Looks like can be closed.

@dmkelly
Copy link

dmkelly commented Jul 8, 2015

I believe this is an issue with the documentation in the readme. I ran into this as well. The readme specifies using outputDir when it should be outputFile.

@janeklb
Copy link
Contributor

janeklb commented Jul 8, 2015

outputFile is the older configuration option - the new option (outputDir) is available in master, though I don't believe it's been released in a new version yet.

(if you look at v0.2.2 you'll see outputFile https://github.com/karma-runner/karma-junit-reporter/tree/v0.2.2)

@dignifiedquire
Copy link
Member

@janeklb yes you are right, haven't gotten around to finish my cleanup and pushing a release out yet

@janeklb
Copy link
Contributor

janeklb commented Jul 8, 2015

@dignifiedquire waiting for it :) will you release this as 0.3.x since it's got an API change?

@busches
Copy link

busches commented Jul 8, 2015

@janeklb since it's a breaking release, it should be a major version increase, not just feature.

@dignifiedquire
Copy link
Member

@busches that only applies for versions > 1.0.0, so yes this will go out as 0.3.0

@dignifiedquire
Copy link
Member

And published as 0.3.0

@busches
Copy link

busches commented Jul 8, 2015

That's pretty confusing. What's stopping you from going 1.0, it works and it works well.

@dignifiedquire
Copy link
Member

1.0 release is in the works karma-runner/karma#1406 but it takes some time, and I want to clean up things an bring everything in line before I do it

@dignifiedquire
Copy link
Member

Closing as it seems the issue is resolved, please reopen if this is still a problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants