Update is-wsl to v2.2.0 to detect docker under WSL #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR needs to update the |
|
Thanks for updating this. CI is still complaining about an out-of-date lockfile somehow. Do you have time to look into it? |
|
Thanks! |
This was referenced Oct 12, 2020
Closed
karmarunnerbot
pushed a commit
that referenced
this pull request
Oct 20, 2020
# [2.0.0](v1.3.0...v2.0.0) (2020-10-20) ### Bug Fixes * Bypass WSL check if Firefox is present in WSL environment ([23a5d10](23a5d10)), closes [#107](#107) * Update is-wsl to v2.2.0 to detect docker under WSL ([#116](#116)) ([c585393](c585393)) ### Features * Make Node 10 minimum required version ([480dafd](480dafd)), closes [#118](#118) ### BREAKING CHANGES * Changed minimum required version of node.js from 8 to 10. Node 8 EOL was 2019-12-31.
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is-wsl in previous versions returns true when running in docker under wsl. This then causes an error because the wslpath command is not found.