Add optional port filter based on usb info. (#45)

karliss · web-flow · commit b7057ab517ff · 2024-12-17T21:57:55.000+02:00
diff --git a/inkcut/device/transports/qtserialport/plugin.py b/inkcut/device/transports/qtserialport/plugin.py
@@ -85,8 +85,14 @@ class QtSerialTransport(DeviceTransport):
 
     def open_serial_port(self, config):
         try:
+            port_name = self.config.choose_filtered_port()
+            if not port_name:
+                raise Exception("{} | Could not find suitable port".format(config.port))
+            self.config.port = port_name  # might be updated if there is a filter
+
+
             serial_port = QSerialPort()
-            serial_port.setPortName(config.port)
+            serial_port.setPortName(port_name)
             #Setting the AllDirections flag is supported on all platforms. Windows supports only this mode.
             serial_port.setBaudRate(config.baudrate, QSerialPort.Direction.AllDirections)
             serial_port.setParity(config.map_parity())
diff --git a/inkcut/device/transports/serialport/plugin.py b/inkcut/device/transports/serialport/plugin.py
@@ -20,6 +20,7 @@
 from twisted.internet.protocol import Protocol, connectionDone
 from twisted.internet.serialport import SerialPort
 from serial.tools.list_ports import comports
+import re
 
 from inkcut.device.transports.raw.plugin import RawFdTransport, RawFdProtocol
 
@@ -39,6 +40,11 @@ class SerialConfigBase(Model):
 
     #: Serial port config
     port = Str().tag(config=True)
+
+    port_filter_name = Str().tag(config=True)
+    port_filter_vid = Int().tag(config=True)
+    port_filter_pid = Int().tag(config=True)
+
     baudrate = Int(9600).tag(config=True)
     bytesize = Enum(serial.EIGHTBITS, serial.SEVENBITS, serial.SIXBITS,
                     serial.FIVEBITS).tag(config=True)
@@ -66,6 +72,81 @@ def _default_port(self):
     def refresh(self):
         self.ports = self._default_ports()
 
+    def has_port_filter(self):
+        return self.port_filter_name != "" or self.port_filter_vid > 0 or self.port_filter_pid > 0
+
+    def port_matches(self, port: SerialPortInfo):
+        if self.port_filter_name:
+            if not re.search(self.port_filter_name, port.description):
+                return False
+        if self.port_filter_vid > 0 and port.usb_vid != self.port_filter_vid:
+            return False
+        if self.port_filter_pid > 0 and port.usb_pid != self.port_filter_pid:
+            return False
+        return True
+
+    def clear_filter(self):
+        self.port_filter_name = ""
+        self.port_filter_vid = 0
+        self.port_filter_pid = 0
+
+    def make_filter(self, port_info: SerialPortInfo):
+        self.clear_filter()
+        if not port_info:
+            return
+        if port_info.usb_vid > 0:
+            # usb devices should have both vid and pid
+            self.port_filter_vid = port_info.usb_vid
+            self.port_filter_pid = port_info.usb_pid
+
+            # For now assume that only usb devices will have a meaningful description
+            #
+            # Physical serial ports can't know what's connected to them, but they are
+            # also more likely to have stable device path so there is less need for filter.
+            if port_info.description:
+                text = port_info.description
+                text = text.strip(' -:()')
+                parts = text.split(port_info.device_path)
+                best = ""
+                for part in parts:
+                    if len(part) > len(best):
+                        best = part
+
+                best = best.strip(' -:()')
+
+                if best:
+                    self.port_filter_name = re.escape(best)
+                    if not re.search(self.port_filter_name, port_info.description):
+                        log.warn("Failed to create port description filter for '{}'".format(port_info.description))
+                        self.port_filter_name = ""
+
+    def port_by_path(self, device_path):
+        for port in self.ports:
+            if port.device_path == device_path:
+                return port
+        return None
+
+    def get_matching_port(self):
+        for port in self.ports:
+            if self.port_matches(port):
+                return port
+        return None
+
+    def choose_filtered_port(self):
+        if not self.has_port_filter():
+            return self.port
+
+        self.refresh()
+        port_info = self.port_by_path(self.port)
+        if port_info and self.port_matches(port_info):
+            return port_info.device_path # prefer last used port when suitable
+
+        port_info = self.get_matching_port()
+        if port_info:
+            return port_info.device_path
+
+        return None
+
 
 class SerialConfig(SerialConfigBase):
     def _default_ports(self):
@@ -92,17 +173,22 @@ class SerialTransport(RawFdTransport):
 
     def connect(self):
         config = self.config
-        self.device_path = config.port
         try:
             #: Save a reference
             self.protocol.transport = self
 
             #: Make the wrapper
             self._protocol = RawFdProtocol(self, self.protocol)
 
+            port = self.config.choose_filtered_port()
+            if not port:
+                raise Exception("{} | Could not find suitable port".format(config.port))
+            self.config.port = port  # might be updated if there is a filter
+            self.device_path = config.port
+
             self.connection = SerialPort(
                 self._protocol,
-                config.port,
+                port,
                 reactor,
                 baudrate=config.baudrate,
                 bytesize=config.bytesize,
diff --git a/inkcut/device/transports/serialport/settings.enaml b/inkcut/device/transports/serialport/settings.enaml
@@ -12,45 +12,153 @@ Created on Jul 12, 2015
 """
 import textwrap
 from inkcut.core.utils import load_icon
-from enaml.layout.api import hbox, align, spacer
+from enaml.layout.api import hbox, vbox, align, spacer
 from enaml.qt.QtWidgets import QApplication
-from enaml.widgets.api import Container, Form, Label, ObjectCombo, SpinBox, CheckBox, PushButton
+from enaml.widgets.api import Container, Form, Label, ObjectCombo, SpinBox, CheckBox, PushButton, Menu, Action, Field
+from enaml.validator import IntValidator
+from inkcut.core.api import log
+from enaml.stdlib.message_box import question
 import serial
 
+enamldef HexPair(Field):
+    attr number = 0
+    mask = "HHHH"
+    validator = IntValidator(minimum=0, maximum=0x888ffff, base=16)
+    text << "{:0>4x}".format(number)
+    text :: self.number = int(change['value'], 16)
+    max_length = 4
+
 enamldef SerialPortSettingsView(Container):
     attr model
     attr exclusive = False
+    attr show_all_ports = False
     padding = 0
 
     alias dsrdtr
     func selected_port(port, ports):
-        matches = [p for p in ports if p.device_path == port]
+        matches = [p for p in ports if p.device_path == port and model.port_matches(p)]
         return matches[0] if matches else None
 
+    func get_ports(candidates):
+        if show_all_ports:
+            return candidates
+        else:
+            return [port for port in candidates if model.port_matches(port)]
+
+    func port_string(port):
+        if model.port_matches(port):
+            return str(port)
+        return "{}{}".format(QApplication.translate("serialport", "(not compatible): "), (str(port)))
+
+    func filter_update_confirm(result):
+        if result and result.action == 'accept':
+            return True
+        return False
+
+    func refresh_filter_clear():
+        filter_clear.enabled = model.has_port_filter()
+
     Form:
         Label:
             text = QApplication.translate("serialport", "Port")
         Container:
             padding = 0
             constraints = [
-                hbox(cb, pb),
-                align('v_center', cb, pb)
+                vbox(
+                    hbox(cb, pb),
+                    hbox(filter_label, filter_descr, filter_label_vid, filter_vid,
+                         filter_label_pid, filter_pid, clear_group),
+                 ),
+                align('v_center', cb, pb),
+                align('v_center', filter_label, filter_label_vid, filter_label_pid, filter_descr),
+                (filter_vid.width == 50) | 'medium',
+                (filter_pid.width == 50) | 'medium',
+                filter_vid.width == filter_pid.width
             ]
             ObjectCombo: cb:
-                items << model.ports
+                items << get_ports(model.ports)
                 selected << selected_port(model.port, model.ports)
+                to_string = port_string
                 selected ::
                     port = change['value']
                     if port:
-                        model.port = port.device_path
+                        if not model.port_matches(port):
+                            if filter_update_confirm(question(
+                                    self, '', QApplication.translate("serialport",
+                                    "Port does not match the filter, do you want to update filter?"))):
+                                model.clear_filter()
+                                model.make_filter(port)
+                                model.port = port.device_path
+                                refresh_filter_clear()
+                            else:
+                                model.port = ""
+                                cb.selected = None
+                                cb._refresh_proxy(dict(type='update'))
+                        else:
+                            old_port = change['oldvalue']
+                            if not model.has_port_filter() and\
+                                 (old_port and old_port.device_path != port.device_path):
+                                model.make_filter(port)
+                            model.port = port.device_path
                 tool_tip = textwrap.dedent("""
                 List of serial ports detected by the system. If nothing is here you
                 must install the device driver for your machine.
                 """).strip()
-            PushButton: pb:
-                text = QApplication.translate("serialport", "Refresh")
-                icon = load_icon("arrow_refresh")
-                clicked :: model.refresh()
+            Container: pb:
+                padding = 0
+                constraints = [
+                    hbox(pb2, pb3, spacing=0),
+                    pb2.height == pb3.height,
+                    pb3.width == pb3.height
+                ]
+                hug_width = 'medium'
+                PushButton: pb2:
+                    text = QApplication.translate("serialport", "Refresh")
+                    icon = load_icon("arrow_refresh")
+                    clicked :: model.refresh()
+                PushButton: pb3:
+                    Menu:
+                        Action:
+                            text = QApplication.translate("serialport", "Show all")
+                            checkable = True
+                            checked := show_all_ports
+                            checked :: model.refresh()
+            Label: filter_label:
+                text = QApplication.translate("serialport", "Filter: ")
+            Field: filter_descr:
+                text := model.port_filter_name
+                text :: refresh_filter_clear()
+            Label: filter_label_vid:
+                text = QApplication.translate("serialport", "VID")
+            HexPair: filter_vid:
+                number := model.port_filter_vid
+                number :: refresh_filter_clear()
+                resist_width = 'weak'
+            Label: filter_label_pid:
+                text = QApplication.translate("serialport", "PID")
+            HexPair: filter_pid:
+                number := model.port_filter_pid
+                number :: refresh_filter_clear()
+                resist_width = 'weak'
+            Container: clear_group:
+                padding = 0
+                constraints = [
+                    hbox(filter_clear, pb4, spacing=0),
+                    pb4.height == filter_clear.height,
+                    pb4.width == pb4.height
+                ]
+                PushButton: filter_clear:
+                    text = QApplication.translate("serialport", "Clear")
+                    icon = load_icon("cancel")
+                    clicked ::
+                        model.clear_filter()
+                        model.refresh()
+                        refresh_filter_clear()
+                PushButton: pb4:
+                    Menu:
+                        Action:
+                            text = QApplication.translate("serialport", "Make filter")
+                            triggered :: model.make_filter(cb.selected)
         Label:
             text = QApplication.translate("serialport", "Baudrate")
         SpinBox:
diff --git a/tests/test_app.py b/tests/test_app.py
@@ -30,6 +30,11 @@ def close():
 @pytest.mark.skipif(not is_pyqtgraph_available,
                     reason='pyqtgraph is not available')
 def test_app():
+    # main app will fail to start if there already is a reactor
+    import sys
+    if "twisted.internet.reactor" in sys.modules:
+        sys.modules.pop("twisted.internet.reactor")
+
     # Must close programatically
     Timer(10, lambda: deferred_call(close)).start()
     from inkcut.app import main
diff --git a/tests/transport/test_serial_config.py b/tests/transport/test_serial_config.py
