Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar does not show in Firefox #408

Open
serverless76 opened this issue Aug 31, 2023 · 2 comments
Open

Sidebar does not show in Firefox #408

serverless76 opened this issue Aug 31, 2023 · 2 comments

Comments

@serverless76
Copy link

Firefox version: 114.0.2 (64-bit)
OS: Linux Mint 20

Downloaded promnesia from addons.mozilla.org today.
Not using promnesia backend.

The search page for browser bookmarks and history from promnesia works fine. But sidebar does not show. Nothing happens on clicking the extension icon.

@krillin666
Copy link
Contributor

It is not working for me since almost a year ago, also using Firefox.
The rare sites I've seen it work are:
https://tex.stackexchange.com/
https://nightly.mealie.io/
https://searx.be/
https://www.ultimate-guitar.com/explore
https://soundcloud.com/
https://www.musictheory.net/

But these seem to be an exception because, the rule is that the sidebar never opens @karlicoss
For example, it does not work on duckduckgo.com or none of scientific publishers websites (and I got to a lot of them per day).

@karlicoss
Copy link
Owner

I just completely randomly noticed these lines

await browser.tabs.executeScript(tabId, {file: 'anchorme.js'})
if (opts.sidebar_detect_urls) {
// meh
await browser.tabs.executeScript(tabId, {file: 'sidebar.js'})
}

Which would mean the sidebar won't work if "Detect and linkify URLs in the sidebar" in extension settings is unset 🤦 (it's a bug, I put the wrong script under if statement)
Could you try making sure it's set and checking if sidebar works again?
Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants