Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

format accept snowflake #12

Closed
karitham opened this issue Jan 5, 2022 · 0 comments · Fixed by #13
Closed

format accept snowflake #12

karitham opened this issue Jan 5, 2022 · 0 comments · Fixed by #13
Assignees

Comments

@karitham
Copy link
Owner

karitham commented Jan 5, 2022

Currently most format's signatures accept strings, however, when formatting a user object for example, we are most likely to be using a snowflake.

I think we should change those signatures.

As an example, there is https://github.com/Karitham/corde/blob/b03180c5b02dce529e51035ea226c058f72c1b13/0_example/todo/todo.go#L58

Which would benefit from just taking in a Snowflake.

We could also take in any, and check for string, fmt.Stringer or use fmt.Sprint, but I'm not exactly sure how that'd end up looking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants