Remove no-panic testing because of Windows

 - Windows gives different results than macOS
 - could be fixed by setting lto="thin"?

Author: karip

Cargo.toml

@@ -1,16 +1,12 @@
 [package]
 name = "aifc"
-version = "0.5.0"
+version = "0.5.2"
 edition = "2021"
 
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
 
 [dependencies]
 audio-codec-algorithms = "0.6.0"
-no-panic = { version = "0.1", optional = true }
-
-[features]
-internal-no-panic = ["dep:no-panic"] # no-panic check is only for testing
 
 [dev-dependencies]
 criterion = { version = "0.5.1" }

README.md

@@ -34,7 +34,7 @@ for sample in reader.samples().expect("Can't iterate samples") {
 }
 ```
 
-Writing AIFF-C file (with the default 2 channels, 16 bits/sample, sample rate 44100):
+Writing AIFF-C file with the default 2 channels, 16 bits/sample and sample rate 44100:
 
 ```rust, no_run
 let mut stream = std::io::BufWriter::new(std::fs::File::create("test.aiff").expect("Open failed"));

src/chunks.rs

@@ -2,9 +2,6 @@
 
 use crate::{cast, AifcError, AifcResult, MarkerId, Write};
 
-#[cfg(feature = "internal-no-panic")]
-use no_panic::no_panic;
-
 fn read_u16_from_pos(data: &[u8], pos: &mut usize) -> AifcResult<u16> {
     let Some(pos_end) = pos.checked_add(2) else {
         return Err(AifcError::StdIoError(crate::unexpectedeof()));
@@ -431,7 +428,6 @@ impl Instrument {
     /// the base note value.
     ///
     /// This method doesn't check that the instrument values are in a valid range.
-    #[cfg_attr(feature = "internal-no-panic", no_panic)]
     pub fn copy_to_slice(&self, slice: &mut [u8; 20]) {
         slice[0] = cast::i8_to_u8(self.base_note);
         slice[1] = cast::i8_to_u8(self.detune);

src/f80.rs

@@ -1,10 +1,6 @@
 use crate::cast;
 
-#[cfg(feature = "internal-no-panic")]
-use no_panic::no_panic;
-
 /// Converts a 80-bit extended floating point value to a 64-bit floating point value.
-#[cfg_attr(feature = "internal-no-panic", no_panic)]
 pub fn f80_to_f64(bytes: &[u8]) -> f64 {
     assert_eq!(bytes.len(), 10);
 
@@ -74,7 +70,6 @@ pub fn f80_to_f64(bytes: &[u8]) -> f64 {
 }
 
 /// Converts a 64-bit floating point value to a 80-bit extended floating point value.
-#[cfg_attr(feature = "internal-no-panic", no_panic)]
 pub fn f64_to_f80(value: f64) -> [u8; 10] {
     if !value.is_finite() {
         if !value.is_nan() {

src/lib.rs

@@ -70,9 +70,6 @@
     clippy::checked_conversions,
 )]
 
-#[cfg(feature = "internal-no-panic")]
-use no_panic::no_panic;
-
 // silly way to test rust code blocks in README.md
 // https://doc.rust-lang.org/rustdoc/write-documentation/documentation-tests.html
 #[doc = include_str!("../README.md")]
@@ -223,7 +220,6 @@ pub enum SampleFormat {
 impl SampleFormat {
     /// Returns the size of the decoded sample in bytes.
     /// Custom formats always return 0.
-    #[cfg_attr(feature = "internal-no-panic", no_panic)]
     pub fn decoded_size(&self) -> usize {
         match &self {
             SampleFormat::U8 => 1,
@@ -242,7 +238,6 @@ impl SampleFormat {
 
     /// Returns the size of the sample in the stream in bytes.
     /// CompressedIma4 returns 0. Custom formats return 1 (they are assumed to write single bytes).
-    #[cfg_attr(feature = "internal-no-panic", no_panic)]
     #[inline(always)]
     fn encoded_size(&self) -> u64 {
         match &self {
@@ -261,7 +256,6 @@ impl SampleFormat {
     }
 
     /// Calculates the sample count based on byte length and sample format.
-    #[cfg_attr(feature = "internal-no-panic", no_panic)]
     fn calculate_sample_len(&self, sample_byte_len: u32) -> Option<u64> {
         match self {
             SampleFormat::CompressedIma4 => {
@@ -277,7 +271,6 @@ impl SampleFormat {
     }
 
     /// The maximum channel count for the sample format.
-    #[cfg_attr(feature = "internal-no-panic", no_panic)]
     fn maximum_channel_count(&self) -> i16 {
         match self {
             SampleFormat::CompressedIma4 => 2,
@@ -287,7 +280,6 @@ impl SampleFormat {
 
     /// Returns the COMM chunk's bits per sample value for the writer.
     /// Compressed formats and custom formats return 0.
-    #[cfg_attr(feature = "internal-no-panic", no_panic)]
     fn bits_per_sample(&self) -> u8 {
         match &self {
             SampleFormat::U8 => 8,
@@ -341,7 +333,6 @@ struct CountingWrite<W> where W: Write {
 }
 
 impl<W: Write> CountingWrite<W> {
-    #[cfg_attr(feature = "internal-no-panic", no_panic)]
     pub fn new(handle: W) -> CountingWrite<W> {
         CountingWrite {
             handle,
@@ -367,17 +358,14 @@ impl<W: Write> Write for CountingWrite<W> {
     }
 }
 
-#[cfg_attr(feature = "internal-no-panic", no_panic)]
 fn is_even_u32(value: u32) -> bool {
     value & 1 == 0
 }
 
-#[cfg_attr(feature = "internal-no-panic", no_panic)]
 fn is_even_u64(value: u64) -> bool {
     value & 1 == 0
 }
 
-#[cfg_attr(feature = "internal-no-panic", no_panic)]
 fn is_even_usize(value: usize) -> bool {
     value & 1 == 0
 }

tools/test.sh

@@ -18,9 +18,6 @@ else
     cargo test
 fi
 
-# check that some functions never panic
-cargo test --release --features internal-no-panic
-
 # build the toisto tester for the test suite
 cargo build --example aifc-toisto