Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Able right-click to create new ruby/romaji object. #618

Closed
andy840119 opened this issue May 19, 2021 · 4 comments
Closed

Able right-click to create new ruby/romaji object. #618

andy840119 opened this issue May 19, 2021 · 4 comments
Labels
LyricMaker Implement lyric maker part into karaoke ruleset.
Milestone

Comments

@andy840119
Copy link
Member

This issue is part of #601
Might need to think about how to add/edit text-tag with just single step.
Might consider UX part first.
.
Also if UX part says ok, should think is it able to place/select time-time at the same time?

@andy840119 andy840119 added the LyricMaker Implement lyric maker part into karaoke ruleset. label May 19, 2021
@andy840119
Copy link
Member Author

Inspire from #458
Maybe the user can select the main text to create ruby/romaji.

@andy840119
Copy link
Member Author

And if that so, should think about how to let the main lyric editor knows is creating or edit ruby/romaji mode?

Maybe should add a new property in ILyricEditorState with several states:

  • create ruby
  • create romaji
  • edit

@andy840119
Copy link
Member Author

Guess another alternative way is show the popover after right-click than select "create new ryby/romaji tag."

@andy840119
Copy link
Member Author

Close this issue due to duplicated to the #2007

@andy840119 andy840119 added this to the 2023.0707 milestone Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LyricMaker Implement lyric maker part into karaoke ruleset.
Projects
None yet
Development

No branches or pull requests

1 participant