Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement note checker. #565

Closed
1 of 3 tasks
andy840119 opened this issue Apr 17, 2021 · 2 comments
Closed
1 of 3 tasks

Implement note checker. #565

andy840119 opened this issue Apr 17, 2021 · 2 comments
Labels
editor Karaoke ruleset's editor area enhancement New feature or request
Milestone
2023.0707

Comments

@andy840119
Copy link
Member

andy840119 commented Apr 17, 2021 •
edited
Loading

What should be checked in the note object:

  • should not overlap if not the same singer -> singer property might be removed.
  • should have parent lyric, and parent lyric should in the beatmap.
  • ???

Implement until having ideas about rules.
@andy840119 andy840119 added enhancement New feature or request editor Karaoke ruleset's editor area labels Apr 17, 2021
@andy840119 andy840119 mentioned this issue Apr 18, 2021
Merged
@andy840119
Copy link
Member Author

seems implement second part first.

@andy840119 andy840119 added this to the 2021.0509 milestone Apr 22, 2021
@andy840119 andy840119 removed this from the 2021.0509 milestone May 18, 2021
@andy840119
Copy link
Member Author

Close this issue because not strictly forbidden note overlapping.

@andy840119 andy840119 added this to the 2023.0707 milestone Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
editor Karaoke ruleset's editor area enhancement New feature or request
Projects
None yet
Milestone
2023.0707
Development

No branches or pull requests
1 participant
@andy840119