Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the EditableLyric in the lyric editor. #2257

Closed
andy840119 opened this issue Jul 8, 2024 · 0 comments
Closed

Refactor the EditableLyric in the lyric editor. #2257

andy840119 opened this issue Jul 8, 2024 · 0 comments
Labels
code quality Improve code quality.

Comments

@andy840119
Copy link
Member

EditableLyric is focused display the lyric with several layers:

  • Time-tag
  • Lyric itself.
  • Caret
  • Blueprint.

And there's 3 location will use it:

  • List item in the List layout
  • List item in the compose layout
  • Composer in the compose layout

The main reason why need to refactor this class:

  • Can decide which layer is using in different place.
  • Can adjust the property exposed in the layer.
@andy840119 andy840119 added the code quality Improve code quality. label Jul 8, 2024
@karaoke-dev karaoke-dev locked and limited conversation to collaborators Jul 8, 2024
@andy840119 andy840119 converted this issue into discussion #2258 Jul 8, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Assignees
No one assigned
Labels
code quality Improve code quality.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andy840119