Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement CurrentStageInfo in the karaoke beatmap. #1905

Closed
andy840119 opened this issue Apr 2, 2023 · 1 comment
Closed

Implement CurrentStageInfo in the karaoke beatmap. #1905

andy840119 opened this issue Apr 2, 2023 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@andy840119
Copy link
Member

andy840119 commented Apr 2, 2023

We need a place to store which stage we are currently using in the gamplay/editor.

Guess the bast solution is Add the CurrentStageInfo into KaraokeBeatmap:

  • beatmap processor will get the value from here.
  • Should copy default beatmap stage info into here as default.
  • Should assign the generated beatmap stage info into this property if the stage info is created by the mod.

What if the case if CurrentStageInfo and Stages in the beatmap are empty in the beatmap processor:

  1. might throw the exception for asking user to select the mod in the gameplay.
  2. hint the user that there's no stages in the editor.

Or maybe we should create something like DefaultStageInfo or FallbackStageInfo as default? Not very sure. -> see the idea in the #1906

@andy840119 andy840119 added the enhancement New feature or request label Apr 2, 2023
@andy840119
Copy link
Member Author

Implemented in the #1922.

@andy840119 andy840119 added this to the 2023.0520 milestone Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant