New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot display result screen. #172

Closed

andy840119 opened this issue Sep 13, 2020 · 4 comments

Labels

bug

Milestone

Member

andy840119 commented Sep 13, 2020

Note : Judgement's amount should match hit object's amount.

andy840119 added the bug label

Member Author

andy840119 commented Sep 19, 2020

It's caused by:

Cannot return null in CreateDrawableRepresentation
Use a tricky way to store PropertyDictionary in HitObjectList

Member Author

andy840119 commented Sep 19, 2020

How to implement:

move PropertyDictionary into beatmap(optional)
throw exception if CreateDrawableRepresentation cannot handle object.
hide NotePlayfield if beatmap is not scorable.

Member Author

andy840119 commented Sep 19, 2020

Notice :
NotePlayfield should be always available even hide.

andy840119 mentioned this issue

Should display result screen #174

Merged

Member Author

andy840119 commented Sep 19, 2020

Implemented.

andy840119 closed this as completed

andy840119 added this to the 2020.0926 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment