Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global search Assert.IsNull(expected); to fix some weird check in the test case . #1657

Closed
andy840119 opened this issue Oct 15, 2022 · 1 comment
Closed

Global search Assert.IsNull(expected); to fix some weird check in the test case . #1657

andy840119 opened this issue Oct 15, 2022 · 1 comment
Labels
code quality Improve code quality.
Milestone
2023.0507

Comments

@andy840119
Copy link
Member

For example, should not have the check because we know that expected is null.
image

Should global search:

  • Assert.IsNull(expected);
  • Assert.IsNull
@andy840119 andy840119 added the code quality Improve code quality. label Oct 15, 2022
@andy840119 andy840119 mentioned this issue May 1, 2023
Merged
@andy840119
Copy link
Member Author

Fixed.

@andy840119 andy840119 added this to the 2023.0520 milestone May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code quality Improve code quality.
Projects
None yet
Milestone
2023.0507
Development

No branches or pull requests
1 participant
@andy840119