Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lyric display issue #1641

Closed
U-siro opened this issue Oct 10, 2022 · 4 comments
Closed

Lyric display issue #1641

U-siro opened this issue Oct 10, 2022 · 4 comments
Milestone

Comments

@U-siro
Copy link

U-siro commented Oct 10, 2022

https://cdn.discordapp.com/attachments/1029074596000976928/1029074883088482374/osu_2022-10-11_01-51-57.mp4

for prevent copyright issue, I sent a beatmap file to discord @andy840119
Two issues included :

  • transition is canceled when they disappear too fast
  • some lyrics are drawn over other one
@andy840119
Copy link
Member

transition is canceled when they disappear too fast

Haven't test on the translation for a while ;_;

some lyrics are drawn over other one

it's a knows issue OHO. I remember current start time and end-time is being calculated by the lyric order and the time-tag.
But should let user able to edit it in the beatmap eventually.

@U-siro
Copy link
Author

U-siro commented Oct 11, 2022

I mean transition, not translation.
I'm saying about when text is fading out, highlighting text is cancelled.
(video time: 0:40)
This song is very fast, so it caused this problem.

@U-siro
Copy link
Author

U-siro commented Oct 11, 2022

This issue is solved. Please check some lyrics are drawn over other one!

@andy840119
Copy link
Member

@U-siro guess this issue is solved after re-design the architecture for able to support different kinds of "stage".

see:
https://blog.karaoke.dev/changelog/2023.0507/

Feel free to open new issue if found anything weird(but i cannot guarantee fix the issue soom).

@andy840119 andy840119 added this to the 2023.0808 milestone Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants