Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all AllowNull attribute eventually. #1411

Closed
andy840119 opened this issue Jun 26, 2022 · 1 comment
Closed

Remove all AllowNull attribute eventually. #1411

andy840119 opened this issue Jun 26, 2022 · 1 comment
Labels
code quality Improve code quality.
Milestone
2023.0707

Comments

@andy840119
Copy link
Member

for now, because not really sure will all BDL property will become like this in the final:

[Resolved]
private GameHost host { get; set; } = null!;

So add the AllowNull attribute for prevent compile error.
And it's easier for searching.

[Resolved, AllowNull]
private GameHost host { get; set; }
@andy840119 andy840119 added the code quality Improve code quality. label Jun 26, 2022
@andy840119 andy840119 mentioned this issue Jun 26, 2022
Merged
@andy840119
Copy link
Member Author

Implemented in the #1988.

@andy840119 andy840119 added this to the 2023.0707 milestone Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code quality Improve code quality.
Projects
None yet
Milestone
2023.0707
Development

No branches or pull requests
1 participant
@andy840119