Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not create bindable everytime in KaraokeLegacySkinTransformer #128

Closed
andy840119 opened this issue Jun 27, 2020 · 3 comments
Closed

Not create bindable everytime in KaraokeLegacySkinTransformer #128

andy840119 opened this issue Jun 27, 2020 · 3 comments
Labels
skin About skin resource
Milestone
2020.0718

Comments

@andy840119
Copy link
Member

See how ConfigManager<TLookup> work and try to initialize all the bindable in PerformLoad()
@andy840119 andy840119 added the skin About skin resource label Jun 27, 2020
@andy840119
Copy link
Member Author

This issue should wait until official change.

@andy840119 andy840119 mentioned this issue Jul 4, 2020
Merged
@andy840119
Copy link
Member Author

This issue can be process because KaraokeLegacySkinTransformer is just a legcay skin support solution.
And karoake's legacy layout and text is always from internal config.

@andy840119 andy840119 added this to the 2020.0718 milestone Jul 4, 2020
@andy840119
Copy link
Member Author

Implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
skin About skin resource
Projects
None yet
Milestone
2020.0718
Development

No branches or pull requests
1 participant
@andy840119