Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move some utils for editor only. #1206

Closed
andy840119 opened this issue Mar 19, 2022 · 3 comments
Closed

Move some utils for editor only. #1206

andy840119 opened this issue Mar 19, 2022 · 3 comments
Labels
code quality Improve code quality. enhancement New feature or request
Milestone

Comments

@andy840119
Copy link
Member

Because some of the utils are for editor only.
.
e.g: cut the lyric or change the text-tag index.

@andy840119 andy840119 added enhancement New feature or request code quality Improve code quality. labels Mar 19, 2022
@andy840119
Copy link
Member Author

Guess should be better to move those utils into the Objects namespace because:

  1. Those utils not only use in the editor.
  2. Those utils should not be global.

@andy840119
Copy link
Member Author

andy840119 commented Jun 20, 2023

Not very sure about this but guess the action like LyricsUtils.SplitLyric should still ok to become a part of utils?

Maybe should rename like GetSplittedLyric? Utils should act like get something, not "doing" something inside.

@andy840119
Copy link
Member Author

This issue can be closed because Hit-object related utils (e.g. display time-tag info or split the lyric) will be moved into the Objects namespace.
see:
#2043

Utils in the Edit namespace only for the logic in the editor only(ui or non-ui).

@andy840119 andy840119 added this to the 2023.0808 milestone Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Improve code quality. enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant