Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MDS AuthenticationAlgorithm enum #449

Closed
micolous opened this issue Sep 20, 2024 · 0 comments · Fixed by #455
Closed

Update MDS AuthenticationAlgorithm enum #449

micolous opened this issue Sep 20, 2024 · 0 comments · Fixed by #455
Assignees

Comments

@micolous
Copy link
Collaborator

MDS has an authenticator with secp521r1_ecdsa_sha512_raw AuthenticationAlgorithm:

{
  "aaguid": "bb405265-40cf-4115-93e5-a332c1968d8c",
  "metadataStatement": {
      "legalHeader": "Submission of this statement and retrieval and use of this statement indicates acceptance of the appropriate agreement located at https://fidoalliance.org/metadata/metadata-legal-terms/.",
      "aaguid": "bb405265-40cf-4115-93e5-a332c1968d8c",
      "friendlyNames": {
          "en-US": "ID-One Card"
      },
      "description": "ID-One Card",
      "authenticatorVersion": 16777216,
      "protocolFamily": "fido2",
      "schema": 3,
      "upv": [
          {
              "major": 1,
              "minor": 1
          },
          {
              "major": 1,
              "minor": 0
          }
      ],
      "authenticationAlgorithms": [
          "secp521r1_ecdsa_sha512_raw",
          "secp256r1_ecdsa_sha256_raw",
          "secp384r1_ecdsa_sha384_raw"
      ],
      "publicKeyAlgAndEncodings": [
          "cose"
      ],
      "attestationTypes": [
          "basic_full"
      ],
...

This doesn't appear in our MDS types:

#[derive(Debug, Clone, Serialize, Deserialize)]
#[serde(deny_unknown_fields)]
/// The list of authentication algorithms supported by the authenticator.
pub enum AuthenticationAlgorithm {

This will need updating, similar to #209

The spec lists a few other types, so may be worth just pulling all of them in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant