Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

svgop.exe does not accept the additional parameters #78

Closed
peng-qd opened this issue Nov 9, 2020 · 1 comment
Closed

svgop.exe does not accept the additional parameters #78

peng-qd opened this issue Nov 9, 2020 · 1 comment

Comments

@peng-qd
Copy link

peng-qd commented Nov 9, 2020

Version of Dianoga

5.0.1

Environment description

Sitecore 8.2.7

What configs you have enabled

Dianoga.DisableForSites.config
Dianoga.Jpeg.config
Dianoga.Png.config
Dianoga.Strategy.MediaCacheAsync.config
Dianoga.Svg.config (and GZip related has been commented out)
Dianoga.WebP.config

Reproducible steps (1... 2... 3...) that cause the issue

Find a svg file that contains viewBox attribute, with default configuration, after optimization, the viewBox attribute is removed.
Now change the "AdditionalToolArguments" to --disable=removeViewBox, clear the mediacache folder, run the page, the viewBox attribute is still removed by Dianoga.

What you expected to see, versus what you actually saw

If the "removeViewBox" plugin has been disabled via the "AdditionalToolArguments", the attribute should be kept.

@markgibbons25
Copy link
Collaborator

Thanks, fixed in 5.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants