Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignoreDescriptionChanges rule missing TYPE_DESCRIPTION_ADDED #2179

Open
4 tasks
Tracked by #2441
dhay opened this issue Sep 21, 2022 · 1 comment
Open
4 tasks
Tracked by #2441

ignoreDescriptionChanges rule missing TYPE_DESCRIPTION_ADDED #2179

dhay opened this issue Sep 21, 2022 · 1 comment
Labels

Comments

@dhay
Copy link

dhay commented Sep 21, 2022

Issue workflow progress

Progress of the issue based on the
Contributor Workflow

  • 1. The issue provides a reproduction available on GitHub, Stackblitz or CodeSandbox

    Make sure to fork this template and run yarn generate in the terminal.

    Please make sure the Codegen and plugins version under package.json matches yours.

  • 2. A failing test has been provided
  • 3. A local solution has been provided
  • 4. A pull request is pending review

Describe the bug

To Reproduce Steps to reproduce the behavior:

Expected behavior

The ignoreDescriptionChanges rule is missing the TypeDescriptionAdded from the list of change types that it ignores.

expect(await diff(
  buildSchema(`type MyType { id: ID! }`,
  buildSchema(`"""Description here""" type MyType { id: ID! }`), [
    DiffRule.ignoreDescriptionChanges
  ])).toHaveLength(0);

However, this fails with a change type of "TYPE_DESCRIPTION_ADDED"

Environment:

  • OS:
  • @graphql-inspector/...: 3.4.0
  • graphql: 16.6.0
  • NodeJS: 16.14.2

Additional context

@theguild-bot theguild-bot mentioned this issue Apr 16, 2023
39 tasks
@theguild-bot theguild-bot mentioned this issue Oct 26, 2023
38 tasks
@czarek-floenergy
Copy link

It's also missing the TYPE_DESCRIPTION_REMOVED rule.

@dotansimha dotansimha added the core label Feb 11, 2025 — with Linear
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants