feat: custom (experimental) indentation option #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamadorueda
force-pushed
the
3timeslazy
branch
from
dafc500
to
9828d43
Compare
kamadorueda
force-pushed
the
3timeslazy
branch
from
9828d43
to
4c815a9
Compare
3timeslazy
reviewed
Nov 26, 2024
| @@ -99,7 +100,12 @@ fn build_step( | |||
| add_token( | |||
| builder, | |||
| rnix::SyntaxKind::TOKEN_WHITESPACE, | |||
| &format!("{0:<1$}", "", 2 * build_ctx.indentation), | |||
| &match build_ctx.config.indentation { | |||
There was a problem hiding this comment.
As we allow the indent customisation, I think it makes sense to allow it fully. That's why I initially proposed the {number}{t | s} syntax in #431.
To make the parsing simple, I would change my initial proposal and disallow the {number} case, like 4, so that either t or s must be always specified.
What do you think?
| @@ -0,0 +1,114 @@ | |||
| [ | |||
There was a problem hiding this comment.
I'd recommend separating the indention and correctness tests as those are different features and their testing logic might change over time. Perhaps, the structure could be
tests/cases
rules
apply
out.nix (uses default 2 spaces indent)
list
...
indentation
apply
out-tabs.nix (uses tabs)
out-{custom} (optional, if we'd like to test different indentations)
list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.