Add support for mocking session storage #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@simonihmig Could you please take a look at this? Recently we faced the need to mock |
simonihmig
approved these changes
Feb 17, 2022
There was a problem hiding this comment.
This totally makes sense, thanks for working on this!
Back then when localStorage support was added, I thought that we could actually add sessionStorage support the same way. But then forgot about it, and apparently nobody cared, until now. So good to have this finally!
|
@simonihmig Thanks a lot for your quick response! Appreciate that 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to add support for mocking
window.sessionStorage.Since both
sessionStorageandlocalStorageimplement the sameStorageAPI this should be straightforward to support.Please, let me know what are your thoughts on this and how this PR can be improved.