Reset to doNothingHandler in tests
#201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the tests are finished, rather than replacing the handler with `null`, it makes more sense to reset the handler back to the default handler. This can be achieved by passing nothing (aka `undefined`) to the `setCurrentHandler` function, as it'll fall back to the default value.
simonihmig
approved these changes
Jul 15, 2020
There was a problem hiding this comment.
Thanks for fixing this, and sorry for the trouble here!
@rwjblue also mentioned this in #191 (comment). The other issue of handling nested usage correctly is something that we can improve a bit later, I'll publish a bugfix release with this in a minute!
simonihmig
changed the title
doNothingHandlerdoNothingHandler in tests
simonihmig
added a commit
that referenced
this pull request
Jul 23, 2020
This adds better test coverage for calls to `setupWindowMock()`, specifically the nested usage discussed with @rwjblue in #191#discussion_r454379796. It turned out that the current implementation (after being fixed by @alexlafroscia in #201) already supports the nested case properly, as the `mockHandler` is set up in the `beforeEach` hook, so as long as there is any nested `setupWindowMock()` the window object will be mocked, and only when a test is not somehow wrapped in a setup call will it see the unmocked window.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the tests are finished, rather than replacing the handler with
null, it makes more sense to reset the handler back to the default handler. This can be achieved by passing nothing (akaundefined) to thesetCurrentHandlerfunction, as it'll fall back to the default value.Our test suite is getting a bunch of instances of trying to call methods on
nullwhen trying to upgrade to0.7.0, and I think the reset tonullhere is the culprit. It's pretty tough to track down which test suite is not mocking the window correctly, but I think this change would get us un-stuck!