From d19f3fb19cef5286f78234e13cc57ba54f260a7e Mon Sep 17 00:00:00 2001 From: Karel Vesely Date: Tue, 25 Sep 2018 18:29:49 +0000 Subject: [PATCH] fixing memory bug in kaldi::~LatticeFasterDecoderTpl(), - found it when running 'latgen-faster-mapped-parallel', - core-dumps from the line: decoder/lattice-faster-decoder.cc:52 -- the line is doing 'delete &(FST*)', i.e. deleting the pointer to FST, instead of deleting the FST itslef, -- bug was probably introduced by refactoring commit d0c68a60 from 2018-09-01, -- after the change the code runs fine... (the unit tests for src/decoder are missing) --- src/decoder/lattice-faster-decoder.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/decoder/lattice-faster-decoder.cc b/src/decoder/lattice-faster-decoder.cc index f78a892e20e..2bc8c7cdef4 100644 --- a/src/decoder/lattice-faster-decoder.cc +++ b/src/decoder/lattice-faster-decoder.cc @@ -49,7 +49,7 @@ template LatticeFasterDecoderTpl::~LatticeFasterDecoderTpl() { DeleteElems(toks_.Clear()); ClearActiveTokens(); - if (delete_fst_) delete &(fst_); + if (delete_fst_) delete fst_; } template