From 3f78ce67b9134a54a9da1927acc38c1e757d5def Mon Sep 17 00:00:00 2001 From: jfainberg Date: Mon, 31 Oct 2016 10:04:59 +0000 Subject: [PATCH] Fixed function calls + removed redundant def sendMail -> SendMail SendMail() removed from train_rnn.py (already declared in nnet3_train_lib) --- egs/wsj/s5/steps/nnet3/train_dnn.py | 4 ++-- egs/wsj/s5/steps/nnet3/train_rnn.py | 16 +++------------- 2 files changed, 5 insertions(+), 15 deletions(-) diff --git a/egs/wsj/s5/steps/nnet3/train_dnn.py b/egs/wsj/s5/steps/nnet3/train_dnn.py index a3764b88492..e4a9e617e48 100755 --- a/egs/wsj/s5/steps/nnet3/train_dnn.py +++ b/egs/wsj/s5/steps/nnet3/train_dnn.py @@ -598,7 +598,7 @@ def Train(args, run_opts): [report, times, data] = nnet3_log_parse.GenerateAccuracyReport(args.dir) message = report subject = "Update : Expt {dir} : Iter {iter}".format(dir = args.dir, iter = iter) - sendMail(message, subject, args.email) + SendMail(message, subject, args.email) num_archives_processed = num_archives_processed + current_num_jobs @@ -646,7 +646,7 @@ def Main(): except Exception as e: if args.email is not None: message = "Training session for experiment {dir} died due to an error.".format(dir = args.dir) - sendMail(message, message, args.email) + SendMail(message, message, args.email) traceback.print_exc() raise e diff --git a/egs/wsj/s5/steps/nnet3/train_rnn.py b/egs/wsj/s5/steps/nnet3/train_rnn.py index 3763fb26303..7ac7a58a3d5 100755 --- a/egs/wsj/s5/steps/nnet3/train_rnn.py +++ b/egs/wsj/s5/steps/nnet3/train_rnn.py @@ -690,7 +690,7 @@ def Train(args, run_opts): [report, times, data] = nnet3_log_parse.GenerateAccuracyReport(args.dir) message = report subject = "Update : Expt {dir} : Iter {iter}".format(dir = args.dir, iter = iter) - sendMail(message, subject, args.email) + SendMail(message, subject, args.email) num_archives_processed = num_archives_processed + current_num_jobs @@ -724,7 +724,7 @@ def Train(args, run_opts): # do some reporting [report, times, data] = nnet3_log_parse.GenerateAccuracyReport(args.dir) if args.email is not None: - sendMail(report, "Update : Expt {0} : complete".format(args.dir), args.email) + SendMail(report, "Update : Expt {0} : complete".format(args.dir), args.email) report_handle = open("{dir}/accuracy.report".format(dir = args.dir), "w") report_handle.write(report) @@ -740,19 +740,9 @@ def Main(): except Exception as e: if args.email is not None: message = "Training session for experiment {dir} died due to an error.".format(dir = args.dir) - sendMail(message, message, args.email) + SendMail(message, message, args.email) traceback.print_exc() raise e -def SendMail(message, subject, email_id): - try: - subprocess.Popen('echo "{message}" | mail -s "{subject}" {email} '.format( - message = message, - subject = subject, - email = email_id), shell=True) - except Exception as e: - logger.info(" Unable to send mail due to error:\n {error}".format(error = str(e))) - pass - if __name__ == "__main__": Main()