Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java: add ability to report positions relative to root stream and add PositionInfo interface #197

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Java: add ability to report positions relative to root stream and add PositionInfo interface #197

wants to merge 4 commits into from

Conversation

Mingun
Copy link
Contributor

@Mingun Mingun commented Feb 23, 2020 •
edited
Loading

New interface PositionInfo introduced to allow to get position information without reflective access in generic way. Closes kaitai-io/kaitai_struct_java_runtime#27

Store offset of streams from begin of root stream in offset field. Fixes kaitai-io/kaitai_struct_java_runtime#26

Depends on runtime changes from kaitai-io/kaitai_struct_java_runtime#28 and test changes in kaitai-io/kaitai_struct_tests#77

Examples of message, file, generated before this PR and after (with --debug key): messages.zip

List of all related issues/PRs:

@Mingun Mingun mentioned this pull request Feb 23, 2020
Open
Mingun added a commit to Mingun/kaitai_struct_tests that referenced this pull request Feb 27, 2020
@Mingun
Fix tests for kaitai-io/kaitai_struct_compiler#197
ca1d5e4
@Mingun Mingun mentioned this pull request Feb 27, 2020
Open
@Mingun
Copy link
Contributor Author

Mingun commented Feb 28, 2020

Can you review this please? I want to move on in improving kaitai_struct_gui, but this and kaitai-io/kaitai_struct_formats#191 are now blockers for that.

@Mingun Mingun force-pushed the absolute-positions branch from ed18cf5 to 851b723 Compare August 9, 2020 05:56
@Mingun
Copy link
Contributor Author

Mingun commented Aug 9, 2020

Let me remind you of myself again. I would be happy if these changes were merged before 0.9 release.

@Mingun
Copy link
Contributor Author

Mingun commented Oct 18, 2020

@GreyCat , @generalmimon I would be super grateful if this feature was included in the 0.9 release

@generalmimon
Copy link
Member

I would be super grateful if this feature was included in the 0.9 release

Unfortunately, this is no longer possible - we released 0.9 the day before yesterday (on October 16, 2020; see https://kaitai.io/news/2020/10/16/kaitai-struct-v0.9-released.html).

I would also like to retrospectively add a couple of things to the 0.9 version (I especially regret breaking backward compatibility on the contents key with repeat and the disappearance of contents in the Graphviz output: comparison), but you just can't delay the release to the point when all bugs are resolved or all nice-to-have features are fully implemented (because that's never gonna happen). We've already waited 2.7 years and that had been already quite embarrassing.

@Mingun
Copy link
Contributor Author

Mingun commented Oct 18, 2020

Well, no one forces wait 3 years until version 0.10. It can be released more quickly :)

@Mingun
Copy link
Contributor Author

Mingun commented Nov 1, 2020

So, what's the verdict on my PRs? Can I expect any comments in them?

@Mingun
Copy link
Contributor Author

Mingun commented Nov 8, 2020

Come on, guys! Is there no one interested in the development of Java backend?

@Mingun Mingun mentioned this pull request Nov 18, 2020
Closed
@Mingun Mingun force-pushed the absolute-positions branch from 851b723 to e95d17e Compare November 19, 2020 17:03
Mingun added a commit to Mingun/kaitai_struct_tests that referenced this pull request Nov 19, 2020
@Mingun
Fix tests for kaitai-io/kaitai_struct_compiler#197
3582eb7
@Mingun Mingun force-pushed the absolute-positions branch from e95d17e to 9c04ebc Compare May 12, 2021 16:01
@Mingun Mingun mentioned this pull request Oct 28, 2021
Merged
@Mingun Mingun mentioned this pull request Jun 3, 2022
Closed
@Mingun Mingun force-pushed the absolute-positions branch from 9c04ebc to 8cccf0a Compare June 4, 2022 16:36
@Mingun Mingun force-pushed the absolute-positions branch from 8cccf0a to 9ce892d Compare April 10, 2023 15:47
Mingun added a commit to Mingun/kaitai_struct_tests that referenced this pull request Apr 10, 2023
@Mingun
Fix tests for kaitai-io/kaitai_struct_compiler#197
7ca592a
@Mingun Mingun force-pushed the absolute-positions branch 2 times, most recently from 5f18aa7 to 81bf464 Compare September 12, 2023 14:44
@Mingun Mingun force-pushed the absolute-positions branch from 81bf464 to 1ce28a6 Compare October 24, 2023 15:33
@Mingun Mingun force-pushed the absolute-positions branch from 1ce28a6 to 05e6d35 Compare March 8, 2024 14:01
Mingun added a commit to Mingun/kaitai_struct_tests that referenced this pull request Mar 8, 2024
@Mingun
Fix tests for kaitai-io/kaitai_struct_compiler#197
d519ddc
Mingun added a commit to Mingun/kaitai_struct_tests that referenced this pull request Apr 6, 2024
@Mingun
Fix tests for kaitai-io/kaitai_struct_compiler#197
763d41d
Mingun added a commit to Mingun/kaitai_struct_tests that referenced this pull request Jul 16, 2024
@Mingun
Fix tests for kaitai-io/kaitai_struct_compiler#197
4504430
@Mingun Mingun force-pushed the absolute-positions branch from 05e6d35 to 3942a45 Compare July 16, 2024 14:26
Mingun added a commit to Mingun/kaitai_struct_tests that referenced this pull request Jul 19, 2024
@Mingun
Fix tests for kaitai-io/kaitai_struct_compiler#197
66db377
@Mingun Mingun force-pushed the absolute-positions branch from 3942a45 to ace4bd0 Compare September 2, 2024 15:41
@Mingun Mingun force-pushed the absolute-positions branch from ace4bd0 to 65b4413 Compare September 8, 2024 07:28
Mingun added a commit to Mingun/kaitai_struct_tests that referenced this pull request Sep 13, 2024
@Mingun
Fix tests for kaitai-io/kaitai_struct_compiler#197
5974df0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GreyCat GreyCat Awaiting requested review from GreyCat

@koczkatamas koczkatamas Awaiting requested review from koczkatamas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Mingun @generalmimon