You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi, thanks for the work you've put into ember-photoswipe, really appreciate it!
I recently upgraded my Ember app to 3.20, but noticed my css minification was breaking with the ember-photoswipe addon. Basically in production, my app's CSS files would be injected in between photoswipe's CSS and override many existing classes, and make my whole app look wrong.
This issue has to do with the instruction to import the addon's css files with this instruction:
@import "ember-photoswipe"
If I remove this line, everything seems to work well.
Do you have any idea how this can be resolved?
I'm currently using ember-cli-sass v^8.0.1.
The text was updated successfully, but these errors were encountered:
Install an Ember 3.20 app (even the tutorial's super-rentals app will do)
Use this photoswipe plugin
Build with CSS minification turned on, i.e. ember build --prod
Run the dist folder with a local http server, e.g. python -m SimpleHTTPServer
If things still look ok here, I understand it might be harder to reproduce.. considering the size of my app's css. Anyway I have created a PR to solve this issue by moving photoswipe to use bower! Please only merge it if other people are facing the same issue - don't want mine to be a one-off
Hi, thanks for the work you've put into ember-photoswipe, really appreciate it!
I recently upgraded my Ember app to 3.20, but noticed my css minification was breaking with the ember-photoswipe addon. Basically in production, my app's CSS files would be injected in between photoswipe's CSS and override many existing classes, and make my whole app look wrong.
This issue has to do with the instruction to import the addon's css files with this instruction:
If I remove this line, everything seems to work well.
Do you have any idea how this can be resolved?
I'm currently using
ember-cli-sass v^8.0.1
.The text was updated successfully, but these errors were encountered: