Bump cni plugins to v1.2.0-k3s1 #7425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add bandwidth and firewall plugins. The bandwidth plugin is automatically registered with the appropriate capability, but the firewall plugin must be configured by the user if they want to use it. Ref: https://www.cni.dev/plugins/current/meta/firewall/ Signed-off-by: Brad Davidson <[email protected]>
briandowns
approved these changes
May 4, 2023
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #7425 +/- ##
=======================================
Coverage 19.57% 19.57%
=======================================
Files 81 81
Lines 5461 5461
=======================================
Hits 1069 1069
Misses 4170 4170
Partials 222 222
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
root@k3s-server-1:/# /var/lib/rancher/k3s/data/current/bin/cni
CNI plugins plugin v1.2.0-k3s1
CNI protocol versions supported: 0.1.0, 0.2.0, 0.3.0, 0.3.1, 0.4.0, 1.0.0
root@k3s-server-1:/# /var/lib/rancher/k3s/data/current/bin/flannel
CNI flannel plugin v0.21.4 (linux/amd64) commit HEAD built on 2023-05-04T19:19:31ZWhen creating a pod with bandwidth annotations, you should see matching tc configuration in place: root@k3s-server-1:/# kubectl get pod -o yaml | grep -A2 annotations
annotations:
kubernetes.io/egress-bandwidth: 1M
kubernetes.io/ingress-bandwidth: 1M
root@k3s-server-1:/# tc qdisc | grep tbf
qdisc tbf 1: dev veth5b8bbe6a root refcnt 9 rate 1Mbit burst 21474835b lat 4.12e+03s
qdisc tbf 1: dev bwpafb7cee7e704 root refcnt 2 rate 1Mbit burst 21474835b lat 4.12e+03s |
rbrtbnfgl
approved these changes
May 4, 2023
This was referenced May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Bump cni plugins to v1.2.0-k3s1
Also add bandwidth and firewall plugins. The bandwidth plugin is automatically registered with the appropriate capability, but the firewall plugin must be configured by the user if they want to use it.
Bandwidth ref: https://kubernetes.io/docs/reference/labels-annotations-taints/#kubernetes-io-ingress-bandwidth
Firewall ref: https://www.cni.dev/plugins/current/meta/firewall/
Types of Changes
version bump, enhancement
Verification
Testing
Linked Issues
User-Facing Change
Further Comments