Add support for -cover + integration test code coverage
#7415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briandowns
approved these changes
May 2, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #7415 +/- ##
==========================================
+ Coverage 19.57% 19.83% +0.25%
==========================================
Files 81 81
Lines 5461 7604 +2143
==========================================
+ Hits 1069 1508 +439
- Misses 4170 5870 +1700
- Partials 222 226 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dereknola
commented
May 3, 2023
| @@ -128,7 +132,7 @@ if [ ! -x ${INSTALLBIN}/cni ]; then | |||
| fi | |||
|
|
|||
| echo Building k3s | |||
| CGO_ENABLED=1 "${GO}" build -tags "$TAGS" -gcflags="all=${GCFLAGS}" -ldflags "$VERSIONFLAGS $LDFLAGS $STATIC" -o bin/k3s ./cmd/server/main.go | |||
| CGO_ENABLED=1 "${GO}" build $BLDFLAGS -tags "$TAGS" -gcflags="all=${GCFLAGS}" -ldflags "$VERSIONFLAGS $LDFLAGS $STATIC" -o bin/k3s ./cmd/server/main.go | |||
There was a problem hiding this comment.
Note that I am purposely not enclosing BLDFLAGS with quotes. This prevents empty "" from being added when BLDFLAG is not set, which breaks go build
cwayne18
approved these changes
May 4, 2023
dereknola
changed the title
-cover + integration test code coverage-cover + integration test code coverage
brandond
requested changes
May 5, 2023
brandond
reviewed
May 5, 2023
brandond
approved these changes
May 5, 2023
osodracnai
approved these changes
May 5, 2023
Signed-off-by: Derek Nola <[email protected]>
Signed-off-by: Derek Nola <[email protected]>
Signed-off-by: Derek Nola <[email protected]>
Signed-off-by: Derek Nola <[email protected]>
Signed-off-by: Derek Nola <[email protected]>
Signed-off-by: Derek Nola <[email protected]>
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
May 9, 2023
* Add support for -cover in k3s server * Update codecov reporting * Sigterm in StopK3sServer Signed-off-by: Derek Nola <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Adds the new cover flag in go 1.20. This enables us to get complete coverage reports from all our Integration tests.
Types of Changes
Build Feature
Verification
To use the new tool:
GOCOVER=1 makeGOCOVERDIRenv to an empty directory where the metadata + counters will be written togo tool covdatato generate resultsgo tool covdata percent -i $GOCOVERDIRproduces a human readable percentage for all package filesgo tool covdata textfmt -i $GOCOVERDIR -o coverage.outproduces a report readable by tools like codecov and coverallsTesting
Linked Issues
User-Facing Change
Further Comments