E2E: Startup test cleanup + RunCommand Enhancement #7388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Nola <[email protected]>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #7388 +/- ##
==========================================
+ Coverage 19.35% 19.57% +0.21%
==========================================
Files 81 81
Lines 5445 5461 +16
==========================================
+ Hits 1054 1069 +15
- Misses 4169 4170 +1
Partials 222 222
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
brandond
reviewed
May 3, 2023
Signed-off-by: Derek Nola <[email protected]>
Signed-off-by: Derek Nola <[email protected]>
Signed-off-by: Derek Nola <[email protected]>
brandond
reviewed
May 4, 2023
brandond
reviewed
May 4, 2023
brandond
reviewed
May 4, 2023
Signed-off-by: Derek Nola <[email protected]>
dereknola
changed the title
brandond
approved these changes
May 5, 2023
cwayne18
approved these changes
May 5, 2023
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
May 9, 2023
* Add beforesuite to startup * Reduce timeouts for startup * Fix cleanup + set kubeconfig Signed-off-by: Derek Nola <[email protected]>
dereknola
added a commit
to osodracnai/k3s
that referenced
this pull request
Jun 9, 2023
* Add beforesuite to startup * Reduce timeouts for startup * Fix cleanup + set kubeconfig Signed-off-by: Derek Nola <[email protected]>
dereknola
added a commit
to osodracnai/k3s
that referenced
this pull request
Jun 9, 2023
* Add beforesuite to startup * Reduce timeouts for startup * Fix cleanup + set kubeconfig Signed-off-by: Derek Nola <[email protected]>
dereknola
added a commit
that referenced
this pull request
Jun 9, 2023
* add private registry e2e test (#7653) add private registry e2e test Signed-off-by: Ian Cardoso <[email protected]> Co-authored-by: Derek Nola <[email protected]> * E2E: Startup test cleanup + RunCommand Enhancement (#7388) * Add beforesuite to startup * Reduce timeouts for startup * Fix cleanup + set kubeconfig Signed-off-by: Derek Nola <[email protected]> --------- Signed-off-by: Ian Cardoso <[email protected]> Signed-off-by: Derek Nola <[email protected]> Co-authored-by: Derek Nola <[email protected]>
dereknola
added a commit
that referenced
this pull request
Jun 9, 2023
* add private registry e2e test (#7653) add private registry e2e test Signed-off-by: Ian Cardoso <[email protected]> Co-authored-by: Derek Nola <[email protected]> * E2E: Startup test cleanup + RunCommand Enhancement (#7388) * Add beforesuite to startup * Reduce timeouts for startup * Fix cleanup + set kubeconfig Signed-off-by: Derek Nola <[email protected]> --------- Signed-off-by: Ian Cardoso <[email protected]> Signed-off-by: Derek Nola <[email protected]> Co-authored-by: Derek Nola <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
RunCommandfunction, removing the need to constantly pass--kubeconfigfor all the kubectl cmdsTypes of Changes
Test Bugfix + Enhancement
Verification
E2E Drone passes consistently now
Testing
Linked Issues
N/A
User-Facing Change
Further Comments