Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MemberList error handling and incorrect etcd-arg passthrough #7371

Merged
merged 1 commit into from
Apr 29, 2023

Conversation

brandond
Copy link
Member

@brandond brandond commented Apr 27, 2023

Proposed Changes

Fix MemberList error handling and incorrect etcd-arg passthrough.

We've apparently never passed through the correct args to the temporary etcd:
ac6325b#diff-784704436cd117bf9d68d125d057633ad1ca5d45139e04998ff7b5f8e0cdb073R828

Types of Changes

bugfix

Verification

Testing

Linked Issues

User-Facing Change

* K3s now correctly passes through etcd-args to the temporary etcd that is used to extract cluster bootstrap data when restarting managed etcd nodes.
* K3s now properly handles errors obtaining the current etcd cluster member list when a new server is joining the managed etcd cluster.

Further Comments

@brandond brandond requested a review from a team as a code owner April 27, 2023 21:19
@brandond brandond force-pushed the fix-etcd-join-temp branch from 94cede6 to 84934d2 Compare April 28, 2023 23:58
@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.03 🎉

Comparison is base (91afb38) 19.32% compared to head (84934d2) 19.35%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7371      +/-   ##
==========================================
+ Coverage   19.32%   19.35%   +0.03%     
==========================================
  Files          81       81              
  Lines        5455     5445      -10     
==========================================
  Hits         1054     1054              
+ Misses       4179     4169      -10     
  Partials      222      222              
Flag Coverage Δ
unittests 19.35% <0.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/etcd/etcd.go 14.58% <0.00%> (+0.13%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants