Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release-1.31] Revert "Make svclb as simple as possible" #11118

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

dereknola
Copy link
Member

Proposed Changes

Backport #11109
This reverts commit 1befd65.

Types of Changes

Verification

Testing

Linked Issues

User-Facing Change


Further Comments

manuelbuil and others added 2 commits October 15, 2024 11:37
This reverts commit 1befd65.

Signed-off-by: manuelbuil <[email protected]>
Signed-off-by: Derek Nola <[email protected]>
Signed-off-by: Derek Nola <[email protected]>
@dereknola dereknola requested a review from a team as a code owner October 15, 2024 21:17
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 62.71186% with 22 lines in your changes missing coverage. Please review.

Project coverage is 43.84%. Comparing base (d74ad42) to head (74678fe).
Report is 1 commits behind head on release-1.31.

Files with missing lines Patch % Lines
pkg/cloudprovider/servicelb.go 62.71% 19 Missing and 3 partials ⚠️

❗ There is a different number of reports uploaded between BASE (d74ad42) and HEAD (74678fe). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (d74ad42) HEAD (74678fe)
e2etests 8 6
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.31   #11118      +/-   ##
================================================
- Coverage         48.88%   43.84%   -5.04%     
================================================
  Files               178      178              
  Lines             14744    14796      +52     
================================================
- Hits               7208     6488     -720     
- Misses             6230     7111     +881     
+ Partials           1306     1197     -109     
Flag Coverage Δ
e2etests 36.20% <62.71%> (-8.73%) ⬇️
inttests 19.81% <0.00%> (-0.08%) ⬇️
unittests 13.59% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dereknola dereknola merged commit 0955fa3 into k3s-io:release-1.31 Oct 16, 2024
30 checks passed
@dereknola dereknola deleted the revert_svclb_131 branch October 23, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants