This repository has been archived by the owner on Jan 6, 2024. It is now read-only.
Respect conditions if present #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piranna
suggested changes
Dec 28, 2021
piranna
suggested changes
Jan 10, 2022
| || key2 === "require" | ||
| || key2 === "node-addons" | ||
| || key2 === "default") { | ||
| if(conditions.indexOf(key) !== -1 |
| || key2 === "require" | ||
| || key2 === "node" | ||
| || key2 === "default") { | ||
| if(conditions.indexOf(key) !== -1 |
| @@ -202,8 +200,7 @@ module.exports = (request, options) => { | |||
| targetFilePath = value; | |||
| else | |||
| for(const [key2, value2] of Object.entries(value)) | |||
| if(key2 === "import" | |||
| || key2 === "require" | |||
| if(conditions.indexOf(key2) !== -1 | |||
There was a problem hiding this comment.
Use includes() here. Also, it should not check for default again, it's an error.
|
Hi @vpzomtrrfrt, your changes inspired me to how to aproach the problem and I think I've fixed it at 900da2e, now conditions are properly enforced and work in (one of) my use cases. Can you update to version 1.1.3 and confirm that it works for you too? If not, please update your PR and I'll merge it :-) |
|
Yes, the latest release appears to work |
Great, good to know :-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also jestjs/jest#11859
There's probably a better way to do this, but this works for my use case at least. Should fix #5