Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIO-310 adding LGTM Badge to ReadMe #316

Merged

Conversation

Lorsen
Copy link
Contributor

@Lorsen Lorsen commented Feb 14, 2019

Fixes #310

Description

Adding LGTM badge image via element.

Motivation and Context

Using LGTM to track introduction of code smells and tech debt. Adding badge to readme to demonstrate that.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@Lorsen Lorsen requested a review from jwu910 as a code owner February 14, 2019 22:24
@jwu910 jwu910 self-assigned this Feb 14, 2019
@jwu910 jwu910 changed the base branch from master to development February 14, 2019 22:25
@jwu910
Copy link
Owner

jwu910 commented Feb 14, 2019

@Lorsen, Thanks for the PR!

I just adjusted the base branch to development instead of master.

Just a heads up, you'll want to update the PR description to say Fixes #310 without the curlies.

@joshuabot
Copy link

Fails
🚫

❔ This pull request should begin with the issue number.
Please include "Fixes #<ISSUE_NUMBER>" at the beginning of the description.
See Contributing Guidelines

Generated by 🚫 dangerJS

@Lorsen
Copy link
Contributor Author

Lorsen commented Feb 14, 2019

Gotcha, made the change!

@jwu910
Copy link
Owner

jwu910 commented Feb 14, 2019

Just started reviewing :)

:octocat: Sent from GH.

@jwu910 jwu910 merged commit 7ee491f into jwu910:development Feb 14, 2019
@jwu910
Copy link
Owner

jwu910 commented Feb 14, 2019

Reviewed Thanks!

@Lorsen Lorsen deleted the CIO-310-AddLGTMBadgeToReadMe branch April 18, 2019 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants