Skip to content
This repository has been archived by the owner on Dec 17, 2020. It is now read-only.

Tests with '/' as part of the name aren't handled correctly #8

Open
jwosty opened this issue Jul 20, 2018 · 0 comments
Open

Tests with '/' as part of the name aren't handled correctly #8

jwosty opened this issue Jul 20, 2018 · 0 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@jwosty
Copy link
Owner

jwosty commented Jul 20, 2018

E.g.

This happens because the extension gets a flat list of tests (names concatenated with slashes) from the external test runner, and therefore can't tell the different between a real slash that was inserted to indicate hierarchy, and a slash that's actually just part of the tests's name. See: /MonoDevelop.UnitTesting.Expecto/ExpectoTestSuites.fs#L251

Possible solutions:

  • Escape slashes in test names in the external test runner (this feels a little dirty but would work)
  • Send the tests back to the client in a tree form (can't use the actual Expecto.Test since this isn't serializable, so we'd have to define our own Test tree type that mirrors it, but without the Expecto.TestCode)
  • Change FlatTestInfo.name to be name: string list instead of name: string, where each element is the hierarchy. (Of course code will have to be changed in the test runner to create the correct structure)
@jwosty jwosty assigned jwosty and unassigned jwosty Jul 20, 2018
@jwosty jwosty added bug Something isn't working help wanted Extra attention is needed labels Jul 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant