From 9b1b841ec36b693ee730c2cfa59f86fbc12c7615 Mon Sep 17 00:00:00 2001 From: jwbron <8340608+jwbron@users.noreply.github.com> Date: Wed, 3 Jun 2026 16:56:58 +0000 Subject: [PATCH 1/2] docs: fix stale no-CLI claims for brc resolve-obligation + read-peer-artifact Slice-5 of #2908 added egg-orch brc resolve-obligation and egg-orch brc read-peer-artifact CLI wrappers, but sandbox/agent-config/rules/orchestrator.md still said "No CLI by design" for both tools. Update the section heading and entries to reflect that CLI aliases now exist, matching the description already in docs/reference/agent-tools.md. Also add the new cmd_brc_resolve_obligation pointer to docs/reference/conditional-ack.md. Authored-by: egg --- docs/reference/conditional-ack.md | 2 +- sandbox/agent-config/rules/orchestrator.md | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/reference/conditional-ack.md b/docs/reference/conditional-ack.md index 31519fa18f..379e5531a1 100644 --- a/docs/reference/conditional-ack.md +++ b/docs/reference/conditional-ack.md @@ -125,5 +125,5 @@ Resolution does not retroactively un-persist a `contract.pr.deferred_actions` en - MCP tool: [`sandbox/egg_agent_tools/tools/brc.py`](../../sandbox/egg_agent_tools/tools/brc.py) — `mcp__brc__resolve_obligation`. - PR body renderer: [`orchestrator/pr_obligations.py`](../../orchestrator/pr_obligations.py) — `render_obligations_section`, `render_obligations_section_from_normalized`, `normalize_deferred_actions`. Shared by the single-PR path (`_build_pre_merge_obligations_section` in `routes/pipelines.py`) and the slice-DAG context-PR path (the obligations section is rendered into the `egg//work → main` context PR body opened at the plan→implement boundary, [#2777](https://github.com/jwbron/egg/issues/2777); the legacy terminal-slice "umbrella PR" treatment was removed). - Contract: [`shared/egg_contracts/models.py`](../../shared/egg_contracts/models.py) — `PRMetadata.deferred_actions`, `DeferredAction`. -- CLI: [`sandbox/egg_lib/orch_cli.py`](../../sandbox/egg_lib/orch_cli.py) — `cmd_consensus_ack`, `cmd_consensus_status`. +- CLI: [`sandbox/egg_lib/orch_cli.py`](../../sandbox/egg_lib/orch_cli.py) — `cmd_consensus_ack`, `cmd_consensus_status`, `cmd_brc_resolve_obligation` (`egg-orch brc resolve-obligation`, added in slice-5 of #2908). - Related: [Concurrent Execution: Reviewer verdict variants](../guides/concurrent-execution.md#reviewer-verdict-variants), [HITL Decisions](../hitl-decisions.md), [Orchestrator CLI](orchestrator-cli.md), [Reviewer Sync](../../shared/prompts/REVIEWER-SYNC.md). diff --git a/sandbox/agent-config/rules/orchestrator.md b/sandbox/agent-config/rules/orchestrator.md index 7f0e960c34..38b58774c5 100644 --- a/sandbox/agent-config/rules/orchestrator.md +++ b/sandbox/agent-config/rules/orchestrator.md @@ -71,12 +71,12 @@ Progress + overseer (iter-2 added the overseer surface): - `mcp__progress__overseer_alert` — Prefer this over `egg-orch overseer alert`. Broadcast an `OVERSEER_ALERT` to all agents in the pipeline. **Producers blocked by reviewer NACKs (or proactive scope questions) on operator-decidable architectural choices — use `mcp__sdlc__register_open_question`, not this. Alerts are informational; decisions are HITL gates. See [`mission.md`](mission.md) → "HITL Decisions vs. Operational Alerts".** - `mcp__progress__query_status` — Prefer this over `egg-orch pipeline status`. Read structured pipeline status (agent matrix, BRC phase, blocked roles). Note: the MCP tool lives in the `progress` namespace per decision-5; the CLI lives in the `pipeline` subcommand subtree (decision-17 keeps the drift-gate symmetric with `overseer_alert`). -No-CLI BRC introspection (iteration 1 + 2): +BRC introspection (#2908): - `mcp__brc__get_state` — Returns the full structured BRC consensus state as JSON. - `mcp__brc__list_blocking` — Returns the list of agent roles currently blocking consensus. -- `mcp__brc__read_peer_artifact` — Reads `.egg-state/brc-history/-.json` filtered by `peer_role` with `limit`/`cursor` pagination. No CLI by design (reviewer-forensics helper; operators inspect the files directly). -- `mcp__brc__resolve_obligation` — Mark a reviewer's conditional-ACK obligation as satisfied in-cycle (#2338). Required: `reviewer_role`, `producer_role`. Optional: `commit_sha`, `note`. The orchestrator rejects self-resolution (`resolver_role == producer_role`), so the producer cannot drive their own resolution — typically the tester (or any non-producer satisfier) calls this after cherry-picking the conditioning commit. No CLI by design; in-cycle resolution flows through the MCP surface. +- `mcp__brc__read_peer_artifact` — Reads `.egg-state/brc-history/-.json` filtered by `peer_role` with `limit`/`cursor` pagination (default `limit=50`, max 500). CLI alias: `egg-orch brc read-peer-artifact` (slice-5 of #2908; registration still `cli_command=None` — see agent-tools.md). +- `mcp__brc__resolve_obligation` — Mark a reviewer's conditional-ACK obligation as satisfied in-cycle (#2338). Required: `reviewer_role`, `producer_role`. Optional: `commit_sha`, `note`. The orchestrator rejects self-resolution (`resolver_role == producer_role`), so the producer cannot drive their own resolution — typically the tester (or any non-producer satisfier) calls this after cherry-picking the conditioning commit. CLI alias: `egg-orch brc resolve-obligation` (slice-5 of #2908; registration still `cli_command=None` — see agent-tools.md). See [`docs/reference/agent-tools.md`](../../../docs/reference/agent-tools.md) for the full 29-verb inventory. From d0069702c40b2ec00e752ddfcaeb78392acc7993 Mon Sep 17 00:00:00 2001 From: "egg-reviewer[bot]" <261018737+egg-reviewer[bot]@users.noreply.github.com> Date: Wed, 3 Jun 2026 17:16:48 +0000 Subject: [PATCH 2/2] docs: note CLI aliases for brc get-state / list-blocking Reviewer flagged that the orchestrator.md bullets for mcp__brc__get_state and mcp__brc__list_blocking didn't mention the CLI aliases added in slice-1 of #2908 (cmd_brc_get_state at orch_cli.py:3231, cmd_brc_list_blocking at orch_cli.py:3263), while the slice-5 entries immediately below them now do. Adds the same CLI alias note for consistency with agent-tools.md:274 which already documents all four slice-1+slice-5 CLI aliases together. --- sandbox/agent-config/rules/orchestrator.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sandbox/agent-config/rules/orchestrator.md b/sandbox/agent-config/rules/orchestrator.md index 38b58774c5..31d955d2af 100644 --- a/sandbox/agent-config/rules/orchestrator.md +++ b/sandbox/agent-config/rules/orchestrator.md @@ -73,8 +73,8 @@ Progress + overseer (iter-2 added the overseer surface): BRC introspection (#2908): -- `mcp__brc__get_state` — Returns the full structured BRC consensus state as JSON. -- `mcp__brc__list_blocking` — Returns the list of agent roles currently blocking consensus. +- `mcp__brc__get_state` — Returns the full structured BRC consensus state as JSON. CLI alias: `egg-orch brc get-state` (slice-1 of #2908; registration still `cli_command=None` — see agent-tools.md). +- `mcp__brc__list_blocking` — Returns the list of agent roles currently blocking consensus. CLI alias: `egg-orch brc list-blocking` (slice-1 of #2908; registration still `cli_command=None` — see agent-tools.md). - `mcp__brc__read_peer_artifact` — Reads `.egg-state/brc-history/-.json` filtered by `peer_role` with `limit`/`cursor` pagination (default `limit=50`, max 500). CLI alias: `egg-orch brc read-peer-artifact` (slice-5 of #2908; registration still `cli_command=None` — see agent-tools.md). - `mcp__brc__resolve_obligation` — Mark a reviewer's conditional-ACK obligation as satisfied in-cycle (#2338). Required: `reviewer_role`, `producer_role`. Optional: `commit_sha`, `note`. The orchestrator rejects self-resolution (`resolver_role == producer_role`), so the producer cannot drive their own resolution — typically the tester (or any non-producer satisfier) calls this after cherry-picking the conditioning commit. CLI alias: `egg-orch brc resolve-obligation` (slice-5 of #2908; registration still `cli_command=None` — see agent-tools.md).