Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a "Virtual Doc" for things like keyhints #58

Open
e-matteson opened this issue Oct 26, 2019 · 1 comment
Open

Make a "Virtual Doc" for things like keyhints #58

e-matteson opened this issue Oct 26, 2019 · 1 comment

Comments

@e-matteson
Copy link
Collaborator

For the future: make a "Virtual Doc" that implements PrettyDocument, b.c. ASTs have a terrible API for this use case, as demonstrated in this method's code. (Add a TODO.)

Originally posted by @justinpombrio in #52

@e-matteson
Copy link
Collaborator Author

After this is done, consider sticking a reference to the keymap manager in the FilteredKeymap struct, and moving the lookup etc. methods onto it. Currently the update_key_hints(&mut self) method makes that impractical for borrow checking reasons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants