From 4f99058cd888634dcd6bb4a1740e475777a31da9 Mon Sep 17 00:00:00 2001 From: resch Date: Sun, 23 Aug 2026 18:52:41 +0000 Subject: [PATCH] test(shape-inference): bump the catalog pin #1860 moved but did not update #1860 registered `pkg.nxrt::KvCacheCapacityAppend`, taking the shape inference registry from 220 operators to 221, without updating the pin that exists to notice exactly that. `expanded_registry_catalog_count_is_pinned` has been failing on `main` ever since, and because it runs in the `Fast`, `Rust coverage` (Linux/Windows/macOS) and `Rust (Windows ARM64)` lanes it reds those lanes on `main` and on every open PR branched from it. The delta is fully accounted for: `df0e45ba3..main` contains exactly one commit touching `crates/onnx-runtime-shape-inference/src/`, and it adds exactly one `reg.register` call. So this is a pin that fell behind a deliberate registration, not an accidental registry change -- 221/266 is the number to pin, not a symptom to chase. Also give both assertions messages. The failure previously read `left: 221, right: 220` with no indication of which direction is correct or what to do, which is a poor signal for something that blocks the whole repo, and the entry count moves independently of the operator count because one operator can carry several opset entries. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- .../onnx-runtime-shape-inference/tests/op_rules.rs | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/crates/onnx-runtime-shape-inference/tests/op_rules.rs b/crates/onnx-runtime-shape-inference/tests/op_rules.rs index d55fc59712..2f866a6985 100644 --- a/crates/onnx-runtime-shape-inference/tests/op_rules.rs +++ b/crates/onnx-runtime-shape-inference/tests/op_rules.rs @@ -283,8 +283,18 @@ fn assert_symbolic(dim: &DimExpr) { #[test] fn expanded_registry_catalog_count_is_pinned() { let registry = InferenceRegistry::default_registry(); - assert_eq!(registry.operator_count(), 220); - assert_eq!(registry.entry_count(), 265); + assert_eq!( + registry.operator_count(), + 221, + "registry operator count moved; if you added or removed a handler, say so by \ + updating this pin in the same commit -- an unbumped pin reds every lane in the repo" + ); + assert_eq!( + registry.entry_count(), + 266, + "registry entry count moved; one operator can carry several opset entries, so this \ + number does not always move in step with the operator count" + ); } fn recurrent_node(op: &str, outputs: usize, direction: &str, hidden_size: i64) -> Node {