From 9e889e47db0037db4f94302609290256d1ea42d4 Mon Sep 17 00:00:00 2001 From: Justin Chu Date: Tue, 18 Aug 2026 23:39:53 +0000 Subject: [PATCH 1/2] style(cuda): rustfmt the split-KV workspace match arm MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit `cargo fmt --all --check` fails on `main` at `standard_attention.rs:2125` — the split-KV workspace sizing added in #1340 landed unformatted because that PR merged while the CI queue was backed up. Every PR's "Rust quality" lane fails on it, in a file the PR does not touch. Whitespace only: rustfmt's own output, no behaviour change. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- .../src/kernels/standard_attention.rs | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/crates/onnx-runtime-ep-cuda/src/kernels/standard_attention.rs b/crates/onnx-runtime-ep-cuda/src/kernels/standard_attention.rs index eb50ce92c4..1c0bd9a457 100644 --- a/crates/onnx-runtime-ep-cuda/src/kernels/standard_attention.rs +++ b/crates/onnx-runtime-ep-cuda/src/kernels/standard_attention.rs @@ -2125,12 +2125,10 @@ impl StandardAttentionKernel { .saturating_mul(q_heads as u64) .saturating_mul(q_seq as u64); let split_bytes = match split_cfg { - Some((num_splits, _)) => attention_split_scratch_floats( - num_splits, - total_rows_u, - v_head_size as u64, - ) - .saturating_mul(std::mem::size_of::()), + Some((num_splits, _)) => { + attention_split_scratch_floats(num_splits, total_rows_u, v_head_size as u64) + .saturating_mul(std::mem::size_of::()) + } None => 0, }; let mut ws = if capture_workspace_eligible { From f4c67670f80f7ba4905ff85a938132322566a776 Mon Sep 17 00:00:00 2001 From: Justin Chu Date: Tue, 18 Aug 2026 23:53:41 +0000 Subject: [PATCH 2/2] ci: unbreak the Rust quality lane on main MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Two independent failures on `main` (c55a3fab3), both in files the failing PRs do not touch, both landed while the Actions queue was backed up so nothing caught them at merge time. Between them they make "is this PR's CI green?" unanswerable for every open PR. 1. `cargo fmt --all --check` fails at `standard_attention.rs:2125` — the split-KV workspace sizing from #1340 is unformatted. Whitespace only, and it is rustfmt's own output on rustc 1.97.1, the toolchain CI resolves `stable` to. 2. `verify_documented_env_vars.py` fails on `ONNX_GENAI_DECODE_GEMV_PROBE_ROWS`, documented by `2026-08-18-multirow-gemv-ceiling-probe.md`. That doc's method section already says the probe was "reverted after measuring" — it is deliberately not shipped, which is exactly what `KNOWN_UNIMPLEMENTED` is for, so it goes there with that reason rather than being wired up. After this commit every step of the `Rust quality` lane passes locally: `cargo fmt --all --check`, `check_publish_order`, `workspace_test_packages verify` (49 tested, 5 denied), `check_profile_table`, `check_platform_naming`, `check_dispatch_reachability`, `check_dispatch_manifest` (+ self-test), `check_feature_gate_coverage`, and `verify_documented_env_vars` (106 documented, 13 known-unimplemented, all accounted for). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- .github/scripts/verify_documented_env_vars.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/scripts/verify_documented_env_vars.py b/.github/scripts/verify_documented_env_vars.py index 6723b99da0..aa060b00c0 100644 --- a/.github/scripts/verify_documented_env_vars.py +++ b/.github/scripts/verify_documented_env_vars.py @@ -74,6 +74,9 @@ "NXRT_SQNBIT_PREFILL_MIN": "referenced in prose about a proposed tuning knob", "ONNX_GENAI_BASE_URL": "client-side variable read by external tooling, not by this workspace", "ONNX_GENAI_SD_PACKAGE": "referenced in prose about a proposed packaging layout", + "ONNX_GENAI_DECODE_GEMV_PROBE_ROWS": "throwaway ceiling-probe flag in " + "2026-08-18-multirow-gemv-ceiling-probe.md, whose method section states the " + "probe was reverted after measuring and is not shipped", } # Uppercase only: the lowercase `onnx_genai_*` names in the docs are Prometheus