Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] provision for secure payment links #5372

Closed
2 tasks done
kashif-m opened this issue Jul 19, 2024 · 0 comments · Fixed by #5357
Closed
2 tasks done

[FEATURE] provision for secure payment links #5372

kashif-m opened this issue Jul 19, 2024 · 0 comments · Fixed by #5357
Assignees
Labels
C-feature Category: Feature request or enhancement

Comments

@kashif-m
Copy link
Contributor

Feature Description

Provide open and secure payment links for different use cases

  • Open links
    • Accessible by anyone
    • Can be opened in new tabs
    • Can be iframed by any host
    • SPMs are never listed
  • Secure links
    • Can be opened only in iframes by allowed_domains (configurable)
    • SPMs can be listed (configurable)

Possible Implementation

When payment links creation is requested, create two links

  • Open
    • Always create this link
  • Secure
    • Create only if allowed_domains are set in the profile
    • If created, store these domains in DB

When payment links render is requested

  • Open - open as is (status vs initiate)
  • Secure
    • Validate if the request is coming from an iframe
    • Validate Origin + Referer headers
    • Client side script to not load the SDK incase iframe is loaded in top

Have you spent some time checking if this feature request has been raised before?

  • I checked and didn't find a similar issue

Have you read the Contributing Guidelines?

Are you willing to submit a PR?

Yes, I am willing to submit a PR!

@kashif-m kashif-m added C-feature Category: Feature request or enhancement S-awaiting-triage Status: New issues that have not been assessed yet labels Jul 19, 2024
@kashif-m kashif-m self-assigned this Jul 19, 2024
@kashif-m kashif-m linked a pull request Jul 19, 2024 that will close this issue
14 tasks
@SanchithHegde SanchithHegde removed the S-awaiting-triage Status: New issues that have not been assessed yet label Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature Category: Feature request or enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants