refactor(router): resolved pr comments for integrity checks

Author: sahkal

crates/common_utils/src/errors.rs

@@ -70,10 +70,11 @@ pub enum ValidationError {
 }
 
 /// Integrity check errors.
-#[allow(missing_docs)] // Only to prevent warnings about struct fields not being documented
 #[derive(Debug, Clone, PartialEq, Default)]
 pub struct IntegrityCheckError {
+    /// Field names for which integrity check failed!
     pub field_names: String,
+    /// Connector transaction reference id
     pub connector_transaction_id: Option<String>,
 }
 

crates/router/src/core/payments/operations/payment_response.rs

@@ -978,6 +978,14 @@ async fn payment_response_update_tracker<F: Clone, T: types::Capturable>(
                                 .change_context(errors::ApiErrorResponse::InternalServerError)
                                 .attach_printable("Could not parse the connector response")?;
 
+                            let auth_update = if Some(router_data.auth_type)
+                                != payment_data.payment_attempt.authentication_type
+                            {
+                                Some(router_data.auth_type)
+                            } else {
+                                None
+                            };
+
                             // incase of success, update error code and error message
                             let error_status =
                                 if router_data.status == enums::AttemptStatus::Charged {
@@ -1018,15 +1026,20 @@ async fn payment_response_update_tracker<F: Clone, T: types::Capturable>(
                                         multiple_capture_data.get_latest_capture().clone(),
                                         capture_update,
                                     )];
-                                    (Some((multiple_capture_data, capture_update_list)), None)
+                                    (Some((multiple_capture_data, capture_update_list)), auth_update.map(|auth_type| {
+                                        storage::PaymentAttemptUpdate::AuthenticationTypeUpdate {
+                                            authentication_type: auth_type,
+                                            updated_by: storage_scheme.to_string(),
+                                        }
+                                    }))
                                 }
                                 None => (
                                     None,
                                     Some(storage::PaymentAttemptUpdate::ResponseUpdate {
                                         status: updated_attempt_status,
                                         connector: None,
                                         connector_transaction_id: connector_transaction_id.clone(),
-                                        authentication_type: None,
+                                        authentication_type: auth_update,
                                         amount_capturable: router_data
                                             .request
                                             .get_amount_capturable(