Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for the document to be synced #148

Merged
merged 2 commits into from
May 10, 2023

Conversation

fcollonval
Copy link
Member

Fixes jupyterlab/jupyterlab#14404

Wait for file content to be synced before triggering websocket connection ready promise

@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023

Binder 👈 Launch a Binder on branch fcollonval/jupyter_server_ydoc/fix/wait-document-sync

@fcollonval fcollonval added the bug Something isn't working label May 9, 2023
Copy link
Member

@hbcarlos hbcarlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @fcollonval !

@hbcarlos hbcarlos merged commit d1d1140 into jupyterlab:main May 10, 2023
@fcollonval fcollonval deleted the fix/wait-document-sync branch May 10, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Always prompts for kernel selection
2 participants